chore(entities): fix drift with browserapplication properties from entities package #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav-new-relic
referenced
this pull request
Jul 3, 2024
pranav-new-relic
deleted the
entites-pkg-cleanup-browser-applications-missing-fix
branch
This was referenced Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
With #1171 merged, the
entitiespackage was cleaned up and the team has been running tests in the New Relic Terraform Provieder with the latest version comprising #1171 (v2.39.1 of the New Relic Go Client) to make sure nothing's broken and everything's running fine.A tiny little glitch was found in one of these Terraform integration tests run on newrelic/terraform-provider-newrelic#2708.
Upon further investigation, the cause was found. This block of code, which may have been manually added (owing to the issues we faced earlier with the entities package in Tutone) kinda got wiped away by our cleanup PR #1171, though we did change the depth of the
entityquery to 3 - it looks like we need greater depth to get these missing attributes.However, to save time on the immediate release of the Terraform Provider we ought to do for an NRQL alert condition PR, I shall be adding this code change manually, and once the release is done, in the next few days, I shall create a PR to change the
entityquery to use depth 4.You may see in the following screenshot that the failing tests's configuration now works fine after this manual addition.