Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade Wix to v5 to fix an issue with non-elevated installs. #2471

Merged
merged 6 commits into from
May 10, 2024

Conversation

jaffinito
Copy link
Member

@jaffinito jaffinito commented May 7, 2024

Description

Upgrades our Wixtoolset version for v3 to v5 to resolve a problem in that version with non-elevated installs.

As part of this change:

  • Used HeatWave, a community tool for wix migrations (and authoring) to migrate away from v3.
  • Migrated the MsiInstaller project files (Installer and InstallerActions) to SDK-style files
  • Updated the InstallerActions project to net481.
  • Wix v5 relies on nuget packages for building and not on a local install of Wix - which does not exist in v5.

Updates dependabot to check the MSI nugets.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@jaffinito jaffinito linked an issue May 8, 2024 that may be closed by this pull request
@jaffinito jaffinito marked this pull request as ready for review May 9, 2024 00:00
@jaffinito jaffinito requested a review from a team as a code owner May 9, 2024 00:00
Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable to me. Do we still have testing to do or do you think we're in good shape?

@chynesNR
Copy link
Member

chynesNR commented May 9, 2024

@nrcventura had a good point -- we should make sure Dependabot is scanning the installer directory to catch new versions of WiX, since it's only a NuGet package now. I'm not positive it'll scan .wixproj files though.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.59%. Comparing base (973492b) to head (f079df8).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2471      +/-   ##
==========================================
+ Coverage   80.43%   80.59%   +0.15%     
==========================================
  Files         450      459       +9     
  Lines       27945    28777     +832     
  Branches     3023     3184     +161     
==========================================
+ Hits        22478    23193     +715     
- Misses       4691     4800     +109     
- Partials      776      784       +8     
Flag Coverage Δ
Agent 81.54% <ø> (+0.13%) ⬆️
Profiler 72.15% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 46 files with indirect coverage changes

@jaffinito jaffinito merged commit acd12fa into main May 10, 2024
87 of 89 checks passed
@jaffinito jaffinito deleted the fix/wix-3to5-upgrade branch May 10, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Wix to v5
4 participants