Update Asp35 instrumentation to ignore Options requests and not use empty names #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JcolemanNR
approved these changes
Jun 23, 2021
...t/NewRelic/Agent/Extensions/Providers/Wrapper/Asp35/IntegratedPipeline/ExecuteStepWrapper.cs
Show resolved
Hide resolved
src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/Asp35/Shared/RouteNamingWrapper.cs
Show resolved
Hide resolved
tests/Agent/IntegrationTests/IntegrationTestHelpers/Assertions.cs
Outdated
Show resolved
Hide resolved
tests/Agent/IntegrationTests/IntegrationTests/RemoteServiceFixtures/WebApiAsyncFixture.cs
Show resolved
Hide resolved
JcolemanNR
previously requested changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #463 and #186 with some updates to the
Asp35instrumentation, adding some checks to ignoreOPTIONSrequests and to not replace transaction names with nothing.Testing
Included are two integration tests for validating that
Mvc3andWebApi2instrumentation is handling and naming these requests correctly.