Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds PipelineWrapper for message send/publish instrumentation. #832

Conversation

vuqtran88
Copy link
Contributor

@vuqtran88 vuqtran88 commented Dec 3, 2021

Adds the PipelineWrapper to instrument message send/publish instrumentation.

Copy link
Member

@jaffinito jaffinito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The wrapper is nice and simple. Keeping the bypasser code outside of the main wrapper makes it much easier to understand.

Copy link
Contributor

@JcolemanNR JcolemanNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vuqtran88 vuqtran88 merged commit 6ba3be7 into nservicebus7-feature-branch Dec 6, 2021
@vuqtran88 vuqtran88 deleted the nservicebus7-publishing-instrumentation branch December 6, 2021 19:23
@jaffinito jaffinito linked an issue Dec 6, 2021 that may be closed by this pull request
jaffinito added a commit that referenced this pull request Dec 17, 2021
* Adds NServiceBus 6/7 message receive instrumentation. (#830)

* Adds NServiceBus 6/7 message receive instrumentation.

* Update ReceiveMessageWrapper.cs

Removes comment which resulted from copy/paste.

* Trigger CI checks on nservicebus7-feature-branch PRs

* Adds PipelineWrapper for message send/publish instrumentation. (#832)

* Migrates NServiceBus 5 tests to use ConsoleMF app (#833)

* Working NSB5 app in ConsoleMF
* Working NServiceBus5Tests
* Working Send and Receive tests
* Remove old NServiceBus files

* Adds NServiceBus to CoreComponents in ArtifactBuilder (#851)

* Add Integration tests for NServiceBus 6/7 (#852)

* NSB 6/7+ Integration tests

* Update to avoid compiling in 4.6.2

* Fix NSB 5 tests, run in CI

* More tests

* Investigate 'Temp' queue name... add debugger launch

* Add remaining tests, Currently the consume naming is hardcoded to the 'temp' queue to pass. The ThrowingCommandHandler tests also fail because 'error_data' is not being reported

* Remove unwanted test that snuck in

* Remove commented copy/paste spam

* Remove change from when the streams got crossed

* Formatting, fix timeout for one fixture

* Cleanup, and reduce length of type names to allow learning transport to work properly for all tests (The throwing handler FW tests weren't working)

* Update test expectations after shortening namespaces

* CR Feedback: Remove explain plan configuration modifications

* Fix issue with bypasser (#856)

- Split out the various calls to the VisibiltyBypasser from the NSB wrappers into their own functions
- Updated tests to account for names now appearing
- Added support for noticing errors from the LoadHandlersConnectorWrapper with test
- Minor formatting and naming changes

* Merge main and update changelog

* NSB: Fix issue with Handler transactions being ended by GC (#858)

* New and improved LoadHandlersConnector Wrapper

* Verify we aren't abandoning any transactions

Co-authored-by: Vu Tran <56414817+vuqtran88@users.noreply.github.com>
Co-authored-by: Josh Coleman <83677148+JcolemanNR@users.noreply.github.com>
Co-authored-by: Josh Coleman <jcoleman@newrelic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NSB6/7 publishing side instrumentation
3 participants