Nservicebus7 feature branch #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds NServiceBus 6/7 message receive instrumentation. Refactoring. * Update ReceiveMessageWrapper.cs Removes comment which resulted from copy/paste.
* Working NSB5 app in ConsoleMF * Working NServiceBus5Tests * Working Send and Receive tests * Remove old NServiceBus files
… nservicebus7-feature-branch
* NSB 6/7+ Integration tests * Update to avoid compiling in 4.6.2 * Fix NSB 5 tests, run in CI * More tests * Investigate 'Temp' queue name... add debugger launch * Add remaining tests, Currently the consume naming is hardcoded to the 'temp' queue to pass. The ThrowingCommandHandler tests also fail because 'error_data' is not being reported * Remove unwanted test that snuck in * Remove commented copy/paste spam * Remove change from when the streams got crossed * Formatting, fix timeout for one fixture * Cleanup, and reduce length of type names to allow learning transport to work properly for all tests (The throwing handler FW tests weren't working) * Update test expectations after shortening namespaces * CR Feedback: Remove explain plan configuration modifications
- Split out the various calls to the VisibiltyBypasser from the NSB wrappers into their own functions - Updated tests to account for names now appearing - Added support for noticing errors from the LoadHandlersConnectorWrapper with test - Minor formatting and naming changes
… nservicebus7-feature-branch
jaffinito
added
bug
jaffinito
requested review from
tehbio,
vuqtran88,
nr-ahemsath and
JcolemanNR
* New and improved LoadHandlersConnector Wrapper * Verify we aren't abandoning any transactions
nr-ahemsath
approved these changes
Dec 16, 2021
|
|
||
| #endregion | ||
|
|
||
| // receive - load; no bypaser in here |
There was a problem hiding this comment.
Will fix in a later PR..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge in NServiceBus 6 and 7 instrumentation feature branch.
Author Checklist
Reviewer Checklist