Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom event's attribute values to have a configurable size #1612

Closed
meiao opened this issue Nov 29, 2023 · 1 comment · Fixed by #1683
Closed

Allow custom event's attribute values to have a configurable size #1612

meiao opened this issue Nov 29, 2023 · 1 comment · Fixed by #1683
Assignees
@meiao
Labels
2 Story Point Estimate jan-mar qtr Represents proposed work item for the Jan-Mar quarter
Milestone
Java Agent - FY24...

Comments

@meiao
Copy link
Contributor

meiao commented Nov 29, 2023

Description

Custom events have attributes and its values are limited to 255 characters by the agent. But the backend supports longer values and it could be useful for customers to have their size increased.

Acceptance Criteria

A new configuration option is created custom_insights_events.max_attribute_value. It will drive the size of the attribute value size. Its default size is 255 and the max value should be 4095. If the customer provides a number higher than this, the value should be capped at 4095 and a warning message is added to the agent logs.
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-184284

@kford-newrelic kford-newrelic added estimate Issue needing estimation jan-mar qtr Represents proposed work item for the Jan-Mar quarter labels Dec 3, 2023
@kford-newrelic kford-newrelic added 2 Story Point Estimate and removed estimate Issue needing estimation labels Dec 13, 2023
@meiao meiao self-assigned this Dec 22, 2023
meiao added a commit that referenced this issue Dec 28, 2023
@meiao
Allow custom event's attribute values to have a configurable size #1612
ef33ad5
@meiao meiao mentioned this issue Jan 8, 2024
Merged
meiao added a commit that referenced this issue Jan 10, 2024
@meiao
Allow custom event's attribute values to have a configurable size #1612…
bcb09e7 
… (#1683)
@meiao meiao linked a pull request Jan 11, 2024 that will close this issue
Allow custom event's attribute values to have a configurable size #1612 #1683
Merged
@meiao meiao closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meiao meiao

Labels
2 Story Point Estimate jan-mar qtr Represents proposed work item for the Jan-Mar quarter
Projects
Java Engineering Board
Archived in project
Milestone
Java Agent - FY24Q4 Quality & Reliabi...
Development

Successfully merging a pull request may close this issue.

Allow custom event's attribute values to have a configurable size #1612 newrelic/newrelic-java-agent
2 participants
@meiao @kford-newrelic