Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom event's attribute values to have a configurable size #1612 #1683

Merged
merged 4 commits into from Jan 10, 2024

Conversation

meiao
Copy link
Contributor

@meiao meiao commented Jan 8, 2024

Overview

Following the agent specs, this PR allows the size of custom event's attributes to be configurable. It uses the current size (255) by default.

Related Github Issue

#1612

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da6c37f) 70.71% compared to head (6ed3bc3) 70.70%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1683      +/-   ##
============================================
- Coverage     70.71%   70.70%   -0.02%     
+ Complexity    10062     9965      -97     
============================================
  Files           830      830              
  Lines         40175    39984     -191     
  Branches       6093     6049      -44     
============================================
- Hits          28411    28270     -141     
+ Misses         9022     8984      -38     
+ Partials       2742     2730      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meiao meiao merged commit bcb09e7 into main Jan 10, 2024
103 checks passed
@meiao meiao deleted the custom-event-attr-size branch January 10, 2024 21:34
@meiao meiao linked an issue Jan 11, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Allow custom event's attribute values to have a configurable size
3 participants