Kafka connect #1324
Kafka connect #1324
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1324 +/- ##
============================================
+ Coverage 61.72% 62.96% +1.23%
- Complexity 8636 8826 +190
============================================
Files 839 836 -3
Lines 40162 40111 -51
Branches 6073 6069 -4
============================================
+ Hits 24790 25254 +464
+ Misses 12891 12342 -549
- Partials 2481 2515 +34 see 37 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
meiao
force-pushed
the
kafka-connect
branch
4 times, most recently
from
f39fb49
to
36c54e3
Compare
| Map<String, Object> eventData = METRICS_AS_EVENTS ? new HashMap<>() : Collections.emptyMap(); | ||
| for (final Map.Entry<String, KafkaMetric> metric : metrics.entrySet()) { | ||
| Object metricValue = metric.getValue().metricValue(); | ||
| if (metricValue instanceof Double) { |
There was a problem hiding this comment.
Why not use metricValue instanceof Number? There could be missing metrics that cast to an integer.
There was a problem hiding this comment.
In addition you can then get your float value like this:
final float value = ((Number) metricValue).floatValue();
There was a problem hiding this comment.
This was copied from the original Kafka metrics instrumentation.
But that is a good change. I checked and apparently they do have integer metrics.
Looks like this traces back to the early versions of the metrics where it always returned doubles.
| private ScheduledFuture<?> scheduledFuture; | ||
|
|
||
| // the metrics are shared between Workers. So only one reporter needs to be attached. | ||
| public static void initialize(ConnectMetrics.MetricGroup metricGroup) { |
There was a problem hiding this comment.
Nice! I'd like to refactor some of the other Kafka metrics reporters in streams/clients to use this approach.
Overview
Adds instrumentation for Kafka Connect.
There are 3 new instrumentation modules.
The first adds support for extracting metrics from Kafka Connect.
The other 2 add transaction tracing, one for versions 2.0.0 up to 3.2.3, and the other for versions 3.3.0 and later.