Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove anorm-2.0 instrumentation module #426

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

jasonjkeller
Copy link
Contributor

@jasonjkeller jasonjkeller commented Sep 13, 2021

This deletes the anorm-2.0 instrumentation module as the artifacts that it instrumented can no longer be publicly downloaded. Furthermore, the range of artifacts that it instrumented ([2.0,2.3-M1)) were all released in 2015 or prior and are likely not worth supporting any longer.

Supportability metrics for instrumentation modules across all accounts during the past month: https://onenr.io/0nVjYVW4eQ0

Usage of this version of the anorm instrumentation is fairly low:

Screen Shot 2021-09-13 at 4 22 22 PM

Compared to more popular instrumentation modules:

Screen Shot 2021-09-13 at 4 25 07 PM

implementation(project(":agent-bridge"))
implementation(project(":newrelic-weaver-api"))
implementation("org.scala-lang:scala-library:2.10.7")
implementation("com.typesafe.play:anorm_2.10:2.3.9")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was incorrectly updated to compile against com.typesafe.play:anorm_2.10:2.3.9 because that is the oldest version available on maven. However, this instrumentation module is only supposed to instrument anorm versions 2.0 up to, but not including 2.3-M1. Thus it was compiling against an unsupported version.

This meant that the instrumentation was weaving a method that no longer existed in version 2.3.9 which was leading to the following WeaveViolations:

     WeaveViolation{type=METHOD_NEW_CALL_ORIGINAL_UNSUPPORTED, clazz=anorm/Sql$, method=as(Lanorm/ResultSetParser;Ljava/sql/ResultSet;)Ljava/lang/Object;}
     WeaveViolation{type=METHOD_NEW_NON_PRIVATE_UNSUPPORTED, clazz=anorm/Sql$, method=as(Lanorm/ResultSetParser;Ljava/sql/ResultSet;)Ljava/lang/Object;}

Copy link
Contributor

@XiXiaPdx XiXiaPdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

@jasonjkeller jasonjkeller merged commit 9b8fe0c into main Sep 14, 2021
@jasonjkeller jasonjkeller deleted the fix-anorm-verifier-failure branch September 14, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants