Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL of New Relic for PHP Docs website used in error messages #334

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

lavarou
Copy link
Member

@lavarou lavarou commented Feb 14, 2022

Use current location of New Relic for PHP Docs website in init scripts as well as in agent code error messages.

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2022

CLA assistant check
All committers have signed the CLA.

@nr-opensource-bot
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@mfulb mfulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks Michal!

Copy link
Contributor

@zsistla zsistla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@lavarou lavarou merged commit 33d4e81 into newrelic:dev Feb 15, 2022
@lavarou lavarou deleted the update-docs-url branch February 15, 2022 14:26
mfulb pushed a commit that referenced this pull request Mar 1, 2022
…334)

fix(agent,axiom,agent/scripts): Update docs website URL
mfulb added a commit that referenced this pull request Mar 1, 2022
* Update to the CI.  Longterm solution should be to store build images. (#193)

* version bump to 9.19

* fix agent readme (#254)

* fix broken dev-integration-tests

* update documentation of failing tests

* add safegaurd check for getting a zval resource id

* add function to get zval object id

* change unnecessary use of macros to functions

* for PHP >= 8, fix to use zv object for curl handle instead of zv resource when getting the handle ID to access the metadata hashmap

* PR comments and PHP 5 compilation fix

* PHP 8.1: Agent changes to support PHP 8.1 (#319)

* Added .dep files to gitignore.

* Allow agent to compile against PHP 8.1 RC2

Add code for request storage handler for existing interned strings.

Fix error callback prototype for PHP >= 8.1.

Fix for PHP >= 8.1 to match MySQL PDO changes to zend_string.

Provide convert_to_explicit_type() macro for PHP >= 8.1 builds.

* Added location to search for future Zend Api Module numbers for ease of reference.

* Add PHP 8.1 to the current GHA PR workflow (#326)

* Added .dep files to gitignore.

* Allow agent to compile against PHP 8.1 RC2

Add code for request storage handler for existing interned strings.

Fix error callback prototype for PHP >= 8.1.

Fix for PHP >= 8.1 to match MySQL PDO changes to zend_string.

Provide convert_to_explicit_type() macro for PHP >= 8.1 builds.

* These cases only apply to PHP 8.0.

* Added location to search for future Zend Api Module numbers for ease of reference.

* Removed ifdefs from within function signatures for readability.

* Clang format issue in the #if statements.

* Adding PHP 8.1 to the workflow.

Co-authored-by: Michael Fulbright <mfulbright@newrelic.com>

* update pgsql instrumenting to 8.1 by using objects instead of resources

* fix pgsql tests for php 8.1

* change tests to define return type when extending for php 8.1

* skip guzzle5 tests for php 8.1+

* change null's to zero'ed types to avoid implicit conversions

* fix pdo test for php 8.1

* adjust error message test for PHP 8.1

* fix msqli class extending test for 8.1

* add guzzle5 skipif to reduce code dup

* add colored output; change ok/not ok to pass/fail

* allow XFAIL description to be missing

* final output 'expected fail' instead of 'xfail'

* replace hard tabs with soft tabs

* Add Symfony 5 support

* CR fix, add named Symfony command transactions

* remove macOS from support development list

* Modified makefiles and docs to support PHP 8.1.

* Typo :)

* Accidental space vs tab.

* test changes required to pass on a modern freebsd system

* forgot to add regex signaler

* Fix LASP test cases affected by PHP 8.1 PDO changes (#333)

* Update URL of New Relic for PHP Docs website used in error messages (#334)

fix(agent,axiom,agent/scripts): Update docs website URL

* Updates to support building PHP 8.1 and installer script (#331)

* Adds PHP 8.1 agent build and install changes

* Remove 5.3 and 5.4 from cases checked

* Remove 5.3 and 5.4 from integration and LASP test runs

* Initialize variable as function can be called multiple times

* Disable 32bit builds for PHP 8.x in GitHub workflow (#336)

* Disable workflow builds of 32bit for PHP 8.x

* Fix TAB to spaces

* Exclude 8.0-zts and 8.1-zts as well for 32 bit builds

* Parametization of release.mk (#337)

* Modified the makefile to accept specific versions to build.
If no versions are supplied, it defaults to all the PHP versions we currently support.
It automatically removes PHP versions that are not supported on the architecture.

This change was made:
* to give more flexibility as PHP versions become deprecated/EOLed on different architectures.
* to  simplifies the release.mk file
* to allow the different versions of PHP to be built depending on build node (e.g. FreeBSD10 vs FreeBSD 13).

Co-authored-by: Amber Sistla <asistla@newrelic.com>
Co-authored-by: Evgeniy <revil-on@mail.ru>
Co-authored-by: Zach Neumann <zneumann@newrelic.com>
Co-authored-by: Piotr Antosik <mail@piotrantosik.com>
Co-authored-by: Michal Nowacki <mnowacki@newrelic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants