Disable 32bit builds for PHP 8.x in GitHub workflow #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsistla
reviewed
Feb 16, 2022
| @@ -42,6 +42,7 @@ jobs: | |||
| arch: ['x64', 'x86'] | |||
| exclude: | |||
| # Excludes PHP 5.x, 7.x on linux 32-bit | |||
| # Excludes PHP 8.x as only 64bit is supported for these versions | |||
There was a problem hiding this comment.
Great start. Can you please exclude 8.0-zts and 8.1-zts as well?
zsistla
approved these changes
Feb 16, 2022
ZNeumann
approved these changes
Feb 18, 2022
mfulb
added a commit
that referenced
this pull request
Mar 1, 2022
* Disable workflow builds of 32bit for PHP 8.x * Fix TAB to spaces * Exclude 8.0-zts and 8.1-zts as well for 32 bit builds
mfulb
added a commit
that referenced
this pull request
Mar 1, 2022
* Update to the CI. Longterm solution should be to store build images. (#193) * version bump to 9.19 * fix agent readme (#254) * fix broken dev-integration-tests * update documentation of failing tests * add safegaurd check for getting a zval resource id * add function to get zval object id * change unnecessary use of macros to functions * for PHP >= 8, fix to use zv object for curl handle instead of zv resource when getting the handle ID to access the metadata hashmap * PR comments and PHP 5 compilation fix * PHP 8.1: Agent changes to support PHP 8.1 (#319) * Added .dep files to gitignore. * Allow agent to compile against PHP 8.1 RC2 Add code for request storage handler for existing interned strings. Fix error callback prototype for PHP >= 8.1. Fix for PHP >= 8.1 to match MySQL PDO changes to zend_string. Provide convert_to_explicit_type() macro for PHP >= 8.1 builds. * Added location to search for future Zend Api Module numbers for ease of reference. * Add PHP 8.1 to the current GHA PR workflow (#326) * Added .dep files to gitignore. * Allow agent to compile against PHP 8.1 RC2 Add code for request storage handler for existing interned strings. Fix error callback prototype for PHP >= 8.1. Fix for PHP >= 8.1 to match MySQL PDO changes to zend_string. Provide convert_to_explicit_type() macro for PHP >= 8.1 builds. * These cases only apply to PHP 8.0. * Added location to search for future Zend Api Module numbers for ease of reference. * Removed ifdefs from within function signatures for readability. * Clang format issue in the #if statements. * Adding PHP 8.1 to the workflow. Co-authored-by: Michael Fulbright <mfulbright@newrelic.com> * update pgsql instrumenting to 8.1 by using objects instead of resources * fix pgsql tests for php 8.1 * change tests to define return type when extending for php 8.1 * skip guzzle5 tests for php 8.1+ * change null's to zero'ed types to avoid implicit conversions * fix pdo test for php 8.1 * adjust error message test for PHP 8.1 * fix msqli class extending test for 8.1 * add guzzle5 skipif to reduce code dup * add colored output; change ok/not ok to pass/fail * allow XFAIL description to be missing * final output 'expected fail' instead of 'xfail' * replace hard tabs with soft tabs * Add Symfony 5 support * CR fix, add named Symfony command transactions * remove macOS from support development list * Modified makefiles and docs to support PHP 8.1. * Typo :) * Accidental space vs tab. * test changes required to pass on a modern freebsd system * forgot to add regex signaler * Fix LASP test cases affected by PHP 8.1 PDO changes (#333) * Update URL of New Relic for PHP Docs website used in error messages (#334) fix(agent,axiom,agent/scripts): Update docs website URL * Updates to support building PHP 8.1 and installer script (#331) * Adds PHP 8.1 agent build and install changes * Remove 5.3 and 5.4 from cases checked * Remove 5.3 and 5.4 from integration and LASP test runs * Initialize variable as function can be called multiple times * Disable 32bit builds for PHP 8.x in GitHub workflow (#336) * Disable workflow builds of 32bit for PHP 8.x * Fix TAB to spaces * Exclude 8.0-zts and 8.1-zts as well for 32 bit builds * Parametization of release.mk (#337) * Modified the makefile to accept specific versions to build. If no versions are supplied, it defaults to all the PHP versions we currently support. It automatically removes PHP versions that are not supported on the architecture. This change was made: * to give more flexibility as PHP versions become deprecated/EOLed on different architectures. * to simplifies the release.mk file * to allow the different versions of PHP to be built depending on build node (e.g. FreeBSD10 vs FreeBSD 13). Co-authored-by: Amber Sistla <asistla@newrelic.com> Co-authored-by: Evgeniy <revil-on@mail.ru> Co-authored-by: Zach Neumann <zneumann@newrelic.com> Co-authored-by: Piotr Antosik <mail@piotrantosik.com> Co-authored-by: Michal Nowacki <mnowacki@newrelic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agent does not support 32 bit environments running PHP 8.x so we can disable these test builds.
This is the corrected version of PR #335 which was improperly setup targeting 'main' instead of the 'dev' branch.