-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agent): Add missing errors decode and prioritization #850
Conversation
Some of the PHP error codes found in php-src\Zend\zend_errors.h were not included. Added the missing codes to properly prioritize and convert to error.class string.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #850 +/- ##
==========================================
+ Coverage 78.71% 78.76% +0.04%
==========================================
Files 193 193
Lines 27109 27125 +16
==========================================
+ Hits 21339 21365 +26
+ Misses 5770 5760 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think with this change, flagging the |
HI @airtonzanon thanks for participating in the repo discussions. |
…hp-agent into error_code_additions
Co-authored-by: Michal Nowacki <mnowacki@newrelic.com>
Add remaining error codes listed in https://github.com/php/php-src/blob/master/Zend/zend_errors.h for completeness in decoding and prioritizing errors.
Added/modified tests accordingly.