Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install correctly on bare bones OSs #913

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

lavarou
Copy link
Member

@lavarou lavarou commented Jun 7, 2024

Some OSs stripped down to bare bones (like base OS container images) don't have all directories needed by the installer (e.g. /etc/init.d). Package installers simply create these directories. Make tarball installer behave similar to package installer and create required directories.

Fixes #905.

Some OSs stripped down to bare bones (like base OS container images) don't
have all directories needed by the installer (e.g. /etc/init.d). Package
installers simply create these directories. Make tarball installer behave
similar to package installer and create required directories.
@lavarou lavarou added this to the next-release milestone Jun 7, 2024
@lavarou lavarou requested review from ZNeumann and zsistla June 7, 2024 20:25
@lavarou lavarou self-assigned this Jun 7, 2024
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Jun 7, 2024

Test Suite Status Result
Multiverse 9/9 passing
SOAK 56/56 passing

Control install process with variables that are documented.
Copy link
Contributor

@zsistla zsistla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lavarou lavarou merged commit bc0766b into dev Jun 10, 2024
65 checks passed
@lavarou lavarou deleted the fix/installer/init-script-install branch June 10, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install script fails on alpine 3.20 for official php docker images
4 participants