Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): Fixes Doctrine 2.18+ detection #916

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

mfulb
Copy link
Contributor

@mfulb mfulb commented Jun 12, 2024

Addresses changes in Doctrine 2.18+ (but not 3.x) that affected detection.

There was a commit for Doctrine 2.18 that reworked the directory structure of the Doctrine library. This PR adds another file for Doctrine to allow it to be auto-detected.

Addresses changes in Doctrine 2.18+ (but not 3.x) that affected detection.
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Jun 12, 2024

Test Suite Status Result
Multiverse 9/9 passing
SOAK 56/56 passing

@mfulb mfulb requested a review from zsistla June 12, 2024 18:47
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (bc0766b) to head (f89a63d).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #916   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         193      193           
  Lines       27214    27214           
=======================================
  Hits        21443    21443           
  Misses       5771     5771           
Flag Coverage Δ
agent-for-php-7.0 77.53% <ø> (ø)
agent-for-php-7.1 77.27% <ø> (ø)
agent-for-php-7.2 78.20% <ø> (ø)
agent-for-php-7.3 78.22% <ø> (ø)
agent-for-php-7.4 77.93% <ø> (ø)
agent-for-php-8.0 77.99% <ø> (ø)
agent-for-php-8.1 77.98% <ø> (ø)
agent-for-php-8.2 77.58% <ø> (ø)
agent-for-php-8.3 77.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lavarou lavarou added this to the next-release milestone Jun 13, 2024
Copy link
Contributor

@zsistla zsistla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating/fixing!

@mfulb mfulb merged commit cf3b2c3 into dev Jun 14, 2024
64 checks passed
@mfulb mfulb deleted the msf/doctrine-218-fix branch June 21, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants