Replace existing release GitHub workflow with a reusable version that adds ARM support #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… adds ARM support Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
ddelnano
force-pushed
the
ddelnano/use-standard-release-github-action-to-release-arm-support
branch
2 times, most recently
from
5ba439f
to
f2fcd00
Compare
etep
approved these changes
Nov 21, 2023
ddelnano
deleted the
ddelnano/use-standard-release-github-action-to-release-arm-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Replace existing release GitHub workflow with a reusable version that adds ARM support
This addresses an issue that prevented the Pixie install through helm from working on ARM nodes. See the GitHub issue below for more details. This deprecates some scripts in this directory and I'll be cleaning that up after the new GitHub action is validated.
I tried to address the security scan failures, but they are blocked behind upgrading our pxapi dependency (#143).
Relevant Issues: newrelic/helm-charts#1152
Test Plan: Modeled this off of an existing repo and will create a
rc(test) release to verify it works