Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAI v1 embeddings errors #1005

Merged
merged 42 commits into from
Dec 16, 2023

Conversation

umaannamalai
Copy link
Contributor

@umaannamalai umaannamalai commented Dec 13, 2023

Overview

Add support for openai v1 embedding error traces and events.

@mergify mergify bot removed the merge-conflicts label Dec 13, 2023
Copy link

github-actions bot commented Dec 13, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 1 0 4.63s
✅ PYTHON black 3 0 0 1.09s
✅ PYTHON flake8 3 0 0.59s
✅ PYTHON isort 3 0 0 0.24s
✅ PYTHON pylint 3 0 3.41s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop-ai-limited-preview@140c7bc). Click here to learn what that means.

❗ Current head 9d38dca differs from pull request most recent head cd5f76a. Consider uploading reports for the commit cd5f76a to get more accurate results

Additional details and impacted files
@@                      Coverage Diff                      @@
##             develop-ai-limited-preview    #1005   +/-   ##
=============================================================
  Coverage                              ?   82.12%           
=============================================================
  Files                                 ?      191           
  Lines                                 ?    20148           
  Branches                              ?     3499           
=============================================================
  Hits                                  ?    16547           
  Misses                                ?     2598           
  Partials                              ?     1003           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the merge-conflicts label Dec 15, 2023
@umaannamalai umaannamalai changed the base branch from develop-ai-limited-preview to develop-ai-limited-preview-3 December 15, 2023 04:19
@umaannamalai umaannamalai changed the base branch from develop-ai-limited-preview-3 to develop-ai-limited-preview December 15, 2023 04:20
@umaannamalai umaannamalai marked this pull request as ready for review December 15, 2023 19:51
@umaannamalai umaannamalai requested a review from a team as a code owner December 15, 2023 19:51
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly just need to fix up the tests now that they are actually running and there's a couple minor fixups in the hook file to handle None cases.

newrelic/hooks/mlmodel_openai.py Outdated Show resolved Hide resolved
newrelic/hooks/mlmodel_openai.py Outdated Show resolved Hide resolved
@validate_span_events(
exact_agents={
"error.message": "create() missing 1 required keyword-only argument: 'model'"
if sys.version_info < (3, 10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh that's annoying.

tests/mlmodel_openai/test_embeddings_error_v1.py Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tests/mlmodel_openai/conftest.py Show resolved Hide resolved
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hmstepanek hmstepanek merged commit 13c3418 into develop-ai-limited-preview Dec 16, 2023
48 of 50 checks passed
@hmstepanek hmstepanek deleted the openai-v1-embeddings-errors branch December 16, 2023 00:10
@mergify mergify bot removed the tests-failing label Dec 16, 2023
@umaannamalai umaannamalai added this to the v9.8.0 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants