Error trace linking #1019
Merged
Error trace linking #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1019 +/- ##
==========================================
- Coverage 81.19% 81.07% -0.12%
==========================================
Files 190 190
Lines 19745 19747 +2
Branches 3468 3468
==========================================
- Hits 16031 16009 -22
- Misses 2724 2743 +19
- Partials 990 995 +5 ☔ View full report in Codecov by Sentry. |
TimPansino
requested changes
Jan 12, 2024
tests/cross_agent/fixtures/distributed_tracing/distributed_tracing.json
Outdated
Show resolved
Hide resolved
tests/testing_support/validators/validate_error_trace_collector_json.py
Outdated
Show resolved
Hide resolved
| @@ -83,7 +83,6 @@ | |||
| "parent.transportType", | |||
| "parent.transportDuration", | |||
| "parentId", | |||
| "guid", | |||
There was a problem hiding this comment.
Let's put this line back as well
There was a problem hiding this comment.
In this case, the distributed tracing intrinsics list goes into an expected absenses attributes list. Since guid is now DT agnostic, it is expected that this make it to the intrinsics list.
TimPansino
approved these changes
Feb 14, 2024
TimPansino
added a commit
that referenced
this pull request
Feb 21, 2024
* Error trace linking (#1019) * Add guid to error event & trace intrinsics w/o DT * Update tests to show guid in intrinsics sans DT * Fix cross agent DT tests and some pylint errors * Remove memcached testing for Python 2.7 * Temporarily pin hypercorn to <0.16 * Remove guid from TracedError & add to intrinsics * Rearrange intrinsics to remove redundancy * Move guid to make it agnostic to DT * Change param initialization type * Use getattr instead of calling root.guid directly * Revert cross agent tests and add guid to DT as well * Separate outside transaction error trace linking * Remove guid from DT specific attribute checks * Fix slow SQL test * Remove guid from JSON * Revert error_trace_collector validator --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Update PyPy in CI to 3.10 (#1065) * Update PyPy3.8 to PyPy3.10 in CI * Fix broken utilization test * Pin CI sha to dev image * Fix failing sklearn test * Unroll sklearn changes * Update falcon tests for 2024 SLAs * Remove pypy38 from image * Unpin dev CI image sha * Change all pypy38 to pypy310 --------- Co-authored-by: Lalleh Rafeei <84813886+lrafeei@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds
guidas an intrinsic field instead of just having a guid in the error trace when Distributed Tracing is enabled. This links the Transaction Error and the Error Trace even if distributed tracing is off, allowing for the user to see more attributes that are attached to the Error Trace in the Errors Inbox UI.