Fix Type Constructor Classes in Code Level Metrics #708

TimPansino · 2022-12-07T18:56:16Z

Overview

Previously either no data was reported or a crash occurred (depending on agent version) when using a class created using the 3 argument type constructor. Fixed and properly returns without line number (which is unavailable).
Pin tox major version to v3 until CI can be fixed.

Related Github Issue

Closes #515

TimPansino · 2022-12-07T18:56:49Z

Problem stemmed from an uncaught OSError, catching all exception types when attempting to find line numbers now.

github-actions · 2022-12-07T18:57:55Z

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Elapsed time
✅ PYTHON	bandit	1		2.47s
✅ PYTHON	black	3	0	0.67s
✅ PYTHON	flake8	3		0.39s
✅ PYTHON	isort	3	0	0.27s
✅ PYTHON	pylint	3		3.19s
✅ YAML	prettier	1	0	0.44s
✅ YAML	v8r	1		2.12s
✅ YAML	yamllint	1		0.19s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

hmstepanek

I fixed some lint errors and converted the helper function into a fixture. Otherwise looks good!

hmstepanek · 2022-12-07T19:35:15Z

tests/agent_features/test_code_level_metrics.py

-            exercise_partial,
-            (),
+
+def extract(obj):


This should be a fixture.

* Fix CLM exception catching * Reorganize CLM Tests * Add type constructor tests to CLM * Fix line number * Pin tox version * Fix lambda tests in CLM * Fix lint issues * Turn helper func into pytest fixture Co-authored-by: Hannah Stepanek <hstepanek@newrelic.com>

TimPansino added 3 commits December 7, 2022 10:50

Fix CLM exception catching

1ac8d22

Reorganize CLM Tests

1b67aab

Add type constructor tests to CLM

7995715

TimPansino requested a review from a team as a code owner December 7, 2022 18:56

TimPansino and others added 5 commits December 7, 2022 11:00

Fix line number

1f65b54

Pin tox version

a51d97d

Fix lambda tests in CLM

b4c176b

Fix lint issues

56352bf

Turn helper func into pytest fixture

ccc6567

hmstepanek approved these changes Dec 7, 2022

View reviewed changes

tests/agent_features/test_code_level_metrics.py Outdated

exercise_partial,

(),

def extract(obj):

Copy link

Contributor

hmstepanek Dec 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a fixture.

hmstepanek merged commit fd0fd01 into main Dec 7, 2022
43 checks passed

hmstepanek deleted the fix-clm-type-constructor-classes branch December 7, 2022 21:50

hmstepanek added this to the v8.5.0 milestone Dec 7, 2022

Fix Type Constructor Classes in Code Level Metrics #708

Fix Type Constructor Classes in Code Level Metrics #708

TimPansino commented Dec 7, 2022 •

edited

TimPansino commented Dec 7, 2022

github-actions bot commented Dec 7, 2022 •

edited

hmstepanek left a comment

hmstepanek Dec 7, 2022

Fix Type Constructor Classes in Code Level Metrics #708

Fix Type Constructor Classes in Code Level Metrics #708

Conversation

TimPansino commented Dec 7, 2022 • edited

Overview

Related Github Issue

TimPansino commented Dec 7, 2022

github-actions bot commented Dec 7, 2022 • edited

🦙 MegaLinter status: ✅ SUCCESS

hmstepanek left a comment

Choose a reason for hiding this comment

hmstepanek Dec 7, 2022

Choose a reason for hiding this comment

TimPansino commented Dec 7, 2022 •

edited

github-actions bot commented Dec 7, 2022 •

edited