Fix deprecation warning from sidekiq error handler

[fukayatsu]

• Before contributing, please read our contributing guidelines and code of conduct.

Overview

Fix deprecation warning: DEPRECATION: Sidekiq exception handlers now take three arguments...

DEPRECATION: Sidekiq exception handlers now take three arguments, see #<Proc:0x00007f9015db7ef8 /home/me/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/newrelic_rpm-9.5.0/lib/new_relic/agent/instrumentation/sidekiq.rb:36>

NOTE: This warning is shown when using sidekiq main branch.

• Remove config from logged context, fixes #6047 sidekiq/sidekiq#6051
• Fix false-positive DEPRECATION message when the error_handler is non-lambda proc sidekiq/sidekiq#6073
• Fix deprecation warning from Sidekiq error handler bugsnag/bugsnag-ruby#796

Submitter Checklist:

• Include a link to the related GitHub issue, if applicable
• [ ] Include a security review link, if applicable

Testing

The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Reviewer Checklist

• Perform code review
• Add performance label
• Perform appropriate level of performance testing
• Confirm all checks passed
• Add version label prior to acceptance

[CLAassistant]

All committers have signed the CLA.

[fukayatsu]

Testing

I tested locally by $ rake 'test:multiverse[sidekiq]' with below diff:

diff --git a/test/multiverse/suites/sidekiq/Envfile b/test/multiverse/suites/sidekiq/Envfile
index 56fee0a97..4f7f19566 100644
--- a/test/multiverse/suites/sidekiq/Envfile
+++ b/test/multiverse/suites/sidekiq/Envfile
@@ -8,13 +8,11 @@ end
 
 SIDEKIQ_VERSIONS = [
   [nil, 2.7],
-  ['6.4.0', 2.5],
-  ['5.0.3', 2.4, 2.5]
 ]
 
 def gem_list(sidekiq_version = nil)
   <<-RB
-    gem 'sidekiq'#{sidekiq_version}
+    gem 'sidekiq', github: 'sidekiq/sidekiq', branch: 'main'
     gem 'newrelic_rpm', :require => false, :path => File.expand_path('../../../../')
   RB
 end
diff --git a/test/multiverse/suites/sidekiq/sidekiq_test_helpers.rb b/test/multiverse/suites/sidekiq/sidekiq_test_helpers.rb
index 0d0546853..c892ddc8b 100644
--- a/test/multiverse/suites/sidekiq/sidekiq_test_helpers.rb
+++ b/test/multiverse/suites/sidekiq/sidekiq_test_helpers.rb
@@ -69,7 +69,7 @@ module SidekiqTestHelpers
     @@cli ||= begin
       cli = Sidekiq::CLI.instance
       cli.parse(['--require', File.absolute_path(__FILE__), '--queue', 'default,1'])
-      cli.logger.instance_variable_get(:@logdev).instance_variable_set(:@dev, File.new('/dev/null', 'w'))
+      # cli.logger.instance_variable_get(:@logdev).instance_variable_set(:@dev, File.new('/dev/null', 'w'))
       ensure_sidekiq_config(cli)
       cli
     end

[kaylareopelle]

Thanks for this fix and your related work in the sidekiq repo, @fukayatsu!