Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixed overlooked workflow change #240

Merged
merged 1 commit into from
Mar 5, 2024
Merged

chore: Fixed overlooked workflow change #240

merged 1 commit into from
Mar 5, 2024

Conversation

jsumners-nr
Copy link
Contributor

Proposed Release Notes

  • Fixed create release GitHub Actions workflow.

Links

Details

In #238 I forgot fix a check in the create release workflow. Basically, a workflow name from my experiment repo was included when it shouldn't have been.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (14c6921) to head (48874db).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files           1        1           
  Lines         183      183           
=======================================
  Hits          179      179           
  Misses          4        4           
Flag Coverage Δ
integration-tests-16-macos-14-arm64 85.24% <ø> (ø)
integration-tests-16-ubuntu-latest-x64 85.24% <ø> (ø)
integration-tests-16-windows-latest-x64 85.24% <ø> (ø)
integration-tests-16-windows-latest-x86 85.24% <ø> (ø)
integration-tests-18-macos-14-arm64 84.15% <ø> (ø)
integration-tests-18-ubuntu-latest-x64 84.15% <ø> (ø)
integration-tests-18-windows-latest-x64 84.15% <ø> (ø)
integration-tests-18-windows-latest-x86 84.15% <ø> (ø)
integration-tests-20-macos-14-arm64 84.15% <ø> (ø)
integration-tests-20-ubuntu-latest-x64 84.15% <ø> (ø)
integration-tests-20-windows-latest-x64 84.15% <ø> (ø)
integration-tests-20-windows-latest-x86 84.15% <ø> (ø)
unit-tests-16-macos-14-arm64 93.44% <ø> (ø)
unit-tests-16-ubuntu-latest-x64 93.44% <ø> (ø)
unit-tests-16-windows-latest-x64 93.44% <ø> (ø)
unit-tests-16-windows-latest-x86 93.44% <ø> (ø)
unit-tests-18-macos-14-arm64 92.34% <ø> (ø)
unit-tests-18-ubuntu-latest-x64 92.34% <ø> (ø)
unit-tests-18-windows-latest-x64 92.34% <ø> (ø)
unit-tests-18-windows-latest-x86 92.34% <ø> (ø)
unit-tests-20-macos-14-arm64 92.34% <ø> (ø)
unit-tests-20-ubuntu-latest-x64 92.34% <ø> (ø)
unit-tests-20-windows-latest-x64 92.34% <ø> (ø)
unit-tests-20-windows-latest-x86 92.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 added the dev:automation Indicates CI automation label Mar 5, 2024
@jsumners-nr jsumners-nr merged commit d7c339a into main Mar 5, 2024
40 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Mar 5, 2024
@jsumners-nr jsumners-nr deleted the fix-workflow branch March 5, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:automation Indicates CI automation
Projects
Archived in project
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants