Arm64 with prebuilds #238
Merged
Arm64 with prebuilds #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
force-pushed
the
arm64-with-prebuilds
branch
from
0ee7dac
to
6bd965d
Compare
jsumners-nr
force-pushed
the
arm64-with-prebuilds
branch
from
e33a24c
to
f3f0b89
Compare
jsumners-nr
force-pushed
the
arm64-with-prebuilds
branch
from
7f73309
to
e07055a
Compare
jsumners-nr
force-pushed
the
arm64-with-prebuilds
branch
from
e07055a
to
5276a1e
Compare
bizob2828
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Nice work 👏🏻 . A few questions and some comments around lack of testing in build.js. This reduces so much manual code to pre build, upload, etc, so much better. I did verify that I could install the .tgz built from the CI and tested the npm run build and instal from source flows.
This PR also addresses or by making irrelevant:
| npm install --verbose --maxsockets 1 | ||
| cp -R node_modules /host/ | ||
| npm run unit | ||
| # Skipping integration until we can get native arm64 runners |
There was a problem hiding this comment.
Not yet. We can file one once we merge this.
bizob2828
approved these changes
Mar 4, 2024
This was referenced Mar 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #205.
Proposed Release Notes
Migrated to using prebuildify and node-gyp-install.
Links
Details
Utilizing prebuildify and node-gyp-install allows us to remove all of the custom code around checking for a local binary and downloading one from an S3 bucket if a binary isn't found. This is accomplished by bundling a binary for all known supported platforms within the npm package. If the module is installed on a platform we have not bundled a binary for, then node-gyp-install will run the build locally as per normal node-gyp. Additionally, if anyone wants to force a build, they can
npm install --build-from-source.Notice: the
create-release.ymlworkflow does not directly use the one fromnewrelic/node-newrelic. We need to do some extra steps to 1. build the binaries, 2. grab them from the GHA artifacts cache, 3. construct a project structure with the binaries andnpm packto build the shippable module, and 4. grab the packed module from the GHA actions cache and then publish it to npmjs.com.The process can be seen in this dry run. The npm-module artifact from that run can be downloaded and:
unzip npm-module.zipmkdir foo && cd foo && npm init && npm install ../newrelic-*.tgzecho -e "const nr = require('@newrelic/native-metrics')\nconsole.log(nr)" > index.jsnode index.jsYou'll see the serialized representation of the exported module since the prebuilt binary gets loaded from the
requireline 😁