feat: Assign pkgVersion and id of all child shim instances when using…

… shim.makeSpecializedShim with a ConglomerateShim instance (#1941)
newrelic · Jan 10, 2024 · d3e393d · d3e393d
1 parent 7d378aa
commit d3e393d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/shim/conglomerate-shim.js b/lib/shim/conglomerate-shim.js
@@ -65,7 +65,15 @@ class ConglomerateShim extends Shim {
    */
   makeSpecializedShim(type, submodule) {
     const ShimClass = SHIM_CLASSES[type]
-    const shim = new ShimClass(this.agent, this.moduleName, this._resolvedName)
+    const shim = new ShimClass(
+      this.agent,
+      this.moduleName,
+      this._resolvedName,
+      null,
+      this.pkgVersion
+    )
+    // associate the parent shim.id with the new submodule
+    shim.id = this.id
     shim._logger = shim._logger.child({ submodule })
     return shim
   }

diff --git a/test/unit/shim/conglomerate-shim.test.js b/test/unit/shim/conglomerate-shim.test.js
@@ -75,6 +75,12 @@ test('ConglomerateShim', (t) => {
     t.equal(shim.moduleName, mod)
     t.equal(agent, shim._agent)
     t.equal(shim.pkgVersion, version)
+    function childFn() {}
+    const childShim = shim.makeSpecializedShim(shim.DATASTORE, childFn)
+    t.same(shim._agent, childShim._agent)
+    t.equal(shim.moduleName, childShim.moduleName)
+    t.equal(shim.pkgVersion, childShim.pkgVersion)
+    t.equal(shim.id, childShim.id)
     t.end()
   })
 })