feat: Assign pkgVersion and id of all child shim instances when using shim.makeSpecializedShim with a ConglomerateShim instance #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shim.makeSpecializedShim with a ConglomerateShim instance
svetlanabrennan
approved these changes
Jan 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1941 +/- ##
=======================================
Coverage 97.02% 97.02%
=======================================
Files 215 215
Lines 40239 40247 +8
=======================================
+ Hits 39040 39048 +8
Misses 1199 1199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Jan 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1883 we added the ability to grab the version of the package via
shim.pkgVersion. There was an oversight when you create a child shim viashim.makeSpecializedShim. It was not using the pkgVersion and id from the parent shim. This PR resolves that so if you are using a shim instance fromshim.makeSpecializedShim,shim.pkgVersionwill be present.