Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express 4 Support #132

Closed
Twipped opened this issue Mar 19, 2014 · 15 comments
Closed

Express 4 Support #132

Twipped opened this issue Mar 19, 2014 · 15 comments

Comments

@Twipped
Copy link

Twipped commented Mar 19, 2014

At @groundwater's recommendation, opening a ticket to track Express 4.0 support, since I'm using it for mash.li.

@othiym23
Copy link
Contributor

It's in progress! It would be very helpful if each major version of Express weren't a nearly total rewrite, but such is life. Thanks for opening this issue!

@alexcurtis
Copy link

👍 Yes Please

@geekatron
Copy link

@othiym23 Is there any ETA with respect to supporting Express 4x?

@mfasanya
Copy link

In the mean time if you just want simple transaction tracking you can use some simple middleware:

app.use(function (req, res, next) {
newrelic.setTransactionName(url.parse(req.url).pathname);
next();
});

@groundwater
Copy link
Contributor

Thanks @geekatron for redirecting #138 this way.

Also thanks @mfasanya for an excellent suggestion on a workaround.

While I personally love using Github for reporting and fixing bugs, feature requests done through here won't be as powerful as through http://support.newrelic.com. As our customer base grows, the support channel becomes our primary funnel for prioritizing feature development.

I will keep this ticket updated!

@Twipped
Copy link
Author

Twipped commented Apr 15, 2014

You were the one that told me to put it here ;)

@groundwater
Copy link
Contributor

@ChiperSoft heh, I'm full of lies! =]

Seriously though, I think having this ticket is great, I just wanted to make sure people know where their voice for feature development is loudest.

@wraithan
Copy link
Contributor

Hello folks!

I have good news for everyone who is running express 4. Express 4 is the poster child for our new feature flags.

In development/staging you can add the following to your newrelic.js:

feature_flag: {
    express4: true
},

This will turn on express 4 support. Keep in mind, this is not super battle hardened, and we don't recommend you run it in production. If you run into any issues, please let us know at http://support.newrelic.com/ with your logs attached so we can analyze them.

Thanks!

@seth-admittedly
Copy link

Any ETA on Express 4 support getting merged into master?

@alexcurtis
Copy link

I think it already is there. I've updated to the latest build and the route names are coming through.

@wraithan
Copy link
Contributor

It is on master behind the flag, supposing everything goes well, we hope to
pull it out from behind the flag very soon.
On Apr 25, 2014 6:18 AM, "Alex Curtis" notifications@github.com wrote:

I think it already is there. I've updated to the latest build and the
route names are coming through.


Reply to this email directly or view it on GitHubhttps://github.com//issues/132#issuecomment-41391081
.

@groundwater
Copy link
Contributor

This has been generally released in version 1.5.3

@samg
Copy link

samg commented May 1, 2014

🤘 😻 🤘

@sarath
Copy link

sarath commented May 20, 2014

Is it to be turned on using the feature flag? or is it by default?

I am using
xxxx.rhcloud.com http:SarathOnlineV8 1.5.5

still not capturing transactions - all captured on /*

@groundwater
Copy link
Contributor

@sarath I think your issue will be best handled through http://support.newrelic.com

cmcadams-newrelic pushed a commit to cmcadams-newrelic/node-newrelic that referenced this issue Jan 29, 2024
…/graphql-koa-dataloader/app/graphql-16.8.1

chore(deps): bump graphql from 16.6.0 to 16.8.1 in /graphql-koa-dataloader/app
bizob2828 added a commit to bizob2828/node-newrelic that referenced this issue Apr 19, 2024
Bumps tap and resolves audit warnings
bizob2828 added a commit to bizob2828/node-newrelic that referenced this issue Apr 23, 2024
Bumps tap and resolves audit warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants