chore: Fix smoke tests node 20 #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1745 +/- ##
==========================================
- Coverage 96.88% 96.88% -0.01%
==========================================
Files 200 200
Lines 39220 39210 -10
Branches 22 22
==========================================
- Hits 37999 37989 -10
Misses 1221 1221
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bizob2828
force-pushed
the
fix-smoke-tests-node-20
branch
from
42a3a32
to
7d03ade
Compare
bizob2828
force-pushed
the
fix-smoke-tests-node-20
branch
from
e7e6854
to
b99146f
Compare
mrickard
reviewed
Aug 3, 2023
mrickard
reviewed
Aug 3, 2023
Co-authored-by: Maurice Rickard <maurice@mauricerickard.com>
mrickard
approved these changes
Aug 3, 2023
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Aug 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy https smoke tests were hanging. I couldn't figure out why but I decided to upgrade the https-proxy-agent library and it immediately resolved the issue. However there was a new issue with hanging but it was on teardown. It turns out up until now the
https-proxy-agentdidn't respect ourkeepAlive: trueoption, now it does. This requires us to destroy the proxy agent which you can see its being done intest/lib/agent_helper.jsby getting the singleton instance and callingdestroy. The upgrade of thehttps-proxy-agentalso required a signature update by passing in a fully constructed URL to the constructor. We have deferred tests to another branch but it would be good to scrutinize that code the most.Closes #1734