test: Added a full suite of unit tests for the collector/http-agents #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrickard <maurice@mauricerickard.com>
…ssertions Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
bizob2828
changed the title
bizob2828
force-pushed
the
mrickard/add-http-agent-unit-tests
branch
from
921cd46
to
6807768
Compare
|
Looks like Node 16 unit tests are failing on the new http-agent test, as it looks for the certificates. |
Yea that wasn't a true unit test. I updated |
Codecov Report
@@ Coverage Diff @@
## main #1748 +/- ##
==========================================
+ Coverage 96.85% 96.88% +0.03%
==========================================
Files 200 200
Lines 39205 39220 +15
Branches 23 22 -1
==========================================
+ Hits 37972 37999 +27
+ Misses 1233 1221 -12
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mrickard
approved these changes
Aug 2, 2023
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Aug 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1745 we will be refactoring the proxy agent. I noticed we lacked unit tests so I asked @mrickard to help adding them. This PR is the suite of tests to improve the proxy agent test coverage