Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Separated running versioned tests between local and external #1792

Merged
merged 2 commits into from Oct 3, 2023

Conversation

bizob2828
Copy link
Member

@bizob2828 bizob2828 commented Oct 3, 2023

This was done to avoid the out of disk space issue with main since we added 1 more container. Since the default runner is only 14 gb, once you start a few containers and collect coverage, it will quickly run out now. By splitting out the external tests we're able to save about 30 minutes in total CI time because the external tests take up a lot of time but when run in parallel they don't have as much of an impact.

We weighed a few options:

  • No longer collecting coverage on main and doing that in a separate job triggered by merges
    • This causes coverage to be out of sync with CI. We previously did this nightly and made the reports confusing.
    • We could try this in the future but this PR seems like the most optimal solution, for now.
  • Using larger runners
    • This costs money and not sure of our cost impact.
    • To me this is the solution to a lot of our problems but we need to do cost analysis and get approval.
  • Splitting out internal and external versioned tests and only collecting coverage for internal(this PR)

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #1792 (23b70b4) into main (9ca78ae) will decrease coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1792      +/-   ##
==========================================
- Coverage   96.84%   96.78%   -0.06%     
==========================================
  Files         198      199       +1     
  Lines       38755    38901     +146     
==========================================
+ Hits        37531    37652     +121     
- Misses       1224     1249      +25     
Flag Coverage Δ
integration-tests-16.x 78.85% <100.00%> (+<0.01%) ⬆️
integration-tests-18.x 79.12% <100.00%> (+<0.01%) ⬆️
integration-tests-20.x 79.12% <100.00%> (-0.01%) ⬇️
unit-tests-16.x 91.38% <85.61%> (-0.03%) ⬇️
unit-tests-18.x 91.36% <85.61%> (-0.03%) ⬇️
unit-tests-20.x 91.36% <85.61%> (-0.03%) ⬇️
versioned-tests-16.x 73.03% <93.83%> (-2.59%) ⬇️
versioned-tests-18.x 73.03% <93.83%> (-2.59%) ⬇️
versioned-tests-20.x 73.04% <93.83%> (-2.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/instrumentation/@elastic/elasticsearch.js 100.00% <100.00%> (ø)
lib/instrumentations.js 100.00% <100.00%> (ø)
lib/shim/datastore-shim.js 99.41% <100.00%> (+<0.01%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrickard mrickard self-assigned this Oct 3, 2023
@bizob2828 bizob2828 merged commit 6ffe2f6 into newrelic:main Oct 3, 2023
29 of 30 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Oct 3, 2023
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants