Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Separated running versioned tests between local and external #1792

Merged
merged 2 commits into from
Oct 3, 2023
Merged

chore: Separated running versioned tests between local and external #1792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b6bdf0
chore: split out running versioned tests into internal and external
bizob2828 Oct 3, 2023
23b70b4
Merge branch 'split-versioned-tests'
bizob2828 Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 26 additions & 3 deletions .github/workflows/ci-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:
name: integration-tests-${{ matrix.node-version }}
path: ./coverage/integration/lcov.info

versioned:
versioned-internal:
needs: skip_if_release
if: needs.skip_if_release.outputs.should_skip != 'true'
runs-on: ubuntu-latest
Expand All @@ -132,7 +132,7 @@ jobs:
- name: Run Docker Services
run: npm run services
- name: Run Versioned Tests
run: TEST_CHILD_TIMEOUT=600000 npm run versioned
run: TEST_CHILD_TIMEOUT=600000 npm run versioned:internal
env:
VERSIONED_MODE: ${{ github.ref == 'refs/heads/main' && '--minor' || '--major' }}
JOBS: 4 # 2 per CPU seems to be the sweet spot in GHA (July 2022)
Expand All @@ -142,9 +142,32 @@ jobs:
with:
name: versioned-tests-${{ matrix.node-version }}
path: ./coverage/versioned/lcov.info

# There is no coverage for external as that's tracked in their respective repos
versioned-external:
needs: skip_if_release
if: needs.skip_if_release.outputs.should_skip != 'true'
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [16.x, 18.x, 20.x]

steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci
- name: Run Versioned Tests
run: TEST_CHILD_TIMEOUT=600000 npm run versioned:external
env:
VERSIONED_MODE: ${{ github.ref == 'refs/heads/main' && '--minor' || '--major' }}
JOBS: 4 # 2 per CPU seems to be the sweet spot in GHA (July 2022)
codecov:
needs: [unit, integration, versioned]
needs: [unit, integration, versioned-internal]
runs-on: ubuntu-latest

strategy:
Expand Down