fix: updated agent to create a stub api when running in a worker thread #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad instead of exiting early to appease the Next.js gods
mrickard
approved these changes
Oct 9, 2023
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Oct 9, 2023
Merged
|
Thank you and the wonderful NewRelic team for the release. I was able to use export default {
experimental: {
appDir: true,
serverComponentsExternalPackages: ["newrelic"], // without this, you will see this Error: Cannot find module './stub_api'
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apparently Next.js does not like early returns in CommonJS files, even though it's valid syntax. This PR updates it to return a stub API in that case, effectively doing nothing but without an early return
Links
Closes #1783