fix: Updated intialization to properly return the api on start up to the security agent #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the security agent
mrickard
approved these changes
Oct 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #1807 +/- ##
=======================================
Coverage 96.82% 96.83%
=======================================
Files 199 199
Lines 38958 38959 +1
=======================================
+ Hits 37723 37724 +1
Misses 1235 1235
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Oct 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1800 we updated the early return and abstracted common initialization code. It properly assigns the API to module.exports but forgets to return the value used for security agent. This fixes that and updates the unit test to assert that the security agent is called with the agent.