Adds Node 16 to CI #772
Merged
Adds Node 16 to CI #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlo-808
reviewed
Jul 22, 2021
package.json
Outdated
| "integration": "npm run prepare-test && npm run sub-install && time tap test/integration/**/**/*.tap.js --timeout=180 --no-coverage", | ||
| "prepare-test": "npm run ca-gen && npm run ssl && npm run docker-env", | ||
| "integration": "npm run prepare-test && npm run sub-install && time tap test/integration/**/**/*.tap.js --timeout=180 --no-coverage --reporter classic", | ||
| "prepare-test": "npm ci && npm run ca-gen && npm run ssl && npm run docker-env", |
There was a problem hiding this comment.
Do we need npm ci here in prepare-test?
There was a problem hiding this comment.
I don't think so. I removed this a few weeks ago because in CI we run npm install before calling any other scripts
There was a problem hiding this comment.
i will fix this and then approve
bizob2828
approved these changes
Jul 22, 2021
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Jul 22, 2021
|
Closes #803 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
Links
Details