Bump tap version #779
Merged
Bump tap version #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
force-pushed
the
bump-tap-version
branch
2 times, most recently
from
05edd7b
to
82e1c74
Compare
bizob2828
force-pushed
the
bump-tap-version
branch
from
82e1c74
to
c13c634
Compare
Closed
bizob2828
force-pushed
the
bump-tap-version
branch
from
c13c634
to
6d82cd0
Compare
bizob2828
force-pushed
the
bump-tap-version
branch
2 times, most recently
from
59d1b78
to
b57b53d
Compare
carlo-808
reviewed
Jul 21, 2021
| @@ -177,7 +181,7 @@ tap.test('Inifinite tracing - Connection Handling', (t) => { | |||
| }) | |||
| }) | |||
|
|
|||
| function testSetup(callback, t) { | |||
| function testSetup(t, callback) { | |||
There was a problem hiding this comment.
+1 for updating the signature
|
|
||
| done() | ||
| }) | ||
| var hostName = getMetricHostName(agent, params.memcached_host) |
There was a problem hiding this comment.
ultra super minor, but could have used const here.
| @@ -292,6 +283,8 @@ test('built-in http module instrumentation', (t) => { | |||
| const segment = transaction.baseSegment | |||
| const spanAttributes = segment.attributes.get(DESTINATIONS.SPAN_EVENT) | |||
|
|
|||
| // TODO: these attrs aren't getting filtered | |||
| // not familiar with code so trying to trace where this is supposed to be removed | |||
There was a problem hiding this comment.
I believe the x-filtered-out header is getting filtered out through attribute filtering wildcard rules. Looks like the regex test is /^(?:response\.(?:headers\.(?:setCookie|x))|request\.(?:headers\.(?:setCookie|x)))/g for filtering out.
There was a problem hiding this comment.
yea i forgot to remove TODO after i traced that
bizob2828
force-pushed
the
bump-tap-version
branch
from
b57b53d
to
f531727
Compare
carlo-808
approved these changes
Jul 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
@newrelic/superagent@newrelic/aws-sdk@newrelic/koa@newrelic/native-metricsand@newrelic/test-utilitiesto the latestLinks
Closes #802
Details
This needs to land before we can re-test #772