Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update semantic release with node #48

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Conversation

rudouglas
Copy link
Contributor

No description provided.

.github/workflows/release.yml Outdated Show resolved Hide resolved
@aswanson-nr aswanson-nr dismissed their stale review September 30, 2021 21:37

Adding a proper change

@@ -170,7 +170,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: 10.x
node-version: 14

- name: Download Cached Deps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it won't let me add a change suggestion to the unedited part of the file. But we should remove this cache step

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aswanson-nr riiiight i should have asked what you meant by that 🏚️ Before I change this on all the rest is my update correct?

Copy link
Contributor

@aswanson-nr aswanson-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got it!

@aswanson-nr aswanson-nr merged commit 7f3e883 into main Oct 1, 2021
@aswanson-nr aswanson-nr deleted the rudouglas-patch-1 branch October 1, 2021 20:08
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants