Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu popover doesn't disappear after you click away from it #42

Closed
danielgolden opened this issue Mar 4, 2020 · 2 comments · Fixed by #46
Closed

Menu popover doesn't disappear after you click away from it #42

danielgolden opened this issue Mar 4, 2020 · 2 comments · Fixed by #46
Assignees
@danielgolden
Labels
bug Something isn't working good first issue Good for newcomers released

Comments

@danielgolden
Copy link
Contributor

Description

On each of the status grid items there is a menu button in the top right of the page. When you click that menu item, the menu popover that appears only ever disappears when you click the button again. If you click away, it doesn't disappear.

Steps to Reproduce

  1. Click on the menu button of any of the status grid items on the page (it looks like a small grey button with 3 dots inside).
  2. Click outside of the menu anywhere on the page.
  3. Notice how the menu does not disappear.

Expected Behaviour

I expect that when I click outside of from the menu (or after a short delay after a mouseOut event) that the menu would disappear.

Your Environment

  • NR1 CLI version used: @datanerd/nr1/1.19.5 darwin-x64 node-v10.16.3
  • Browser name and version: Versión 80.0.3987.122 (Build oficial) (64 bits)
  • Operating System and version: MacOS Catalina 10.15.3 (19D76)
@danielgolden danielgolden added the bug Something isn't working label Mar 4, 2020
@danielgolden danielgolden added the good first issue Good for newcomers label Mar 4, 2020
@danielgolden danielgolden pinned this issue Mar 4, 2020
@danielgolden danielgolden self-assigned this Mar 26, 2020
@danielgolden danielgolden mentioned this issue Mar 26, 2020
Merged
danielgolden added a commit that referenced this issue Mar 27, 2020
@danielgolden
fix: Make popover menu disappear onMouseLeave (#46)
6043ae0 
* fix: Make popover menu disappear onMouseLeave

#42

* chore: remove unused logging
devfreddy pushed a commit that referenced this issue Mar 27, 2020
chore(release): 0.12.1 [skip ci]
46ac3a8 
## [0.12.1](v0.12.0...v0.12.1) (2020-03-27)

### Bug Fixes

* Make popover menu disappear onMouseLeave ([#46](#46)) ([6043ae0](6043ae0)), closes [#42](https://github.com/newrelic/issues/42)
@devfreddy
Copy link
Contributor

🎉 This issue has been resolved in version 0.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@danielgolden
Copy link
Contributor Author

Note to self: Apply this same fix to the newrelic/workloads-geo-ops popovers on the menu button in the "all maps" screen.

@tangollama tangollama unpinned this issue Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielgolden danielgolden

Labels
bug Something isn't working good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Make popover menu disappear onMouseLeave
2 participants
@devfreddy @danielgolden