Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling fixes (like #32) #33

Closed
wants to merge 2 commits into from
Closed

Styling fixes (like #32) #33

wants to merge 2 commits into from

Conversation

danielgolden
Copy link
Contributor

This PR contains fixes for a few issues:

ericSpence
ericSpence approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@ericSpence ericSpence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Looks like the ci build is broken for linting but that appears to be unrelated to the changes that you added

@devfreddy
Copy link
Contributor

After resolving merge conflicts it looks like these changes found another way into the master branch. Closing as merging wouldn't accomplish much.

@devfreddy devfreddy closed this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericSpence ericSpence ericSpence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielgolden @devfreddy @ericSpence