Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

summary-panel renders inconsistently #10

Closed
throck opened this issue Oct 23, 2019 · 2 comments · Fixed by #20
Closed

summary-panel renders inconsistently #10

throck opened this issue Oct 23, 2019 · 2 comments · Fixed by #20
Assignees
@jbeveland27
Labels
bug Something isn't working released
Projects
Open Source and Developer Advocacy Co...

Comments

@throck
Copy link

throck commented Oct 23, 2019

The summary-panel renders inconsistently, when switching between processes. To be more specific, the panel renders on initial load, but then may not render at all when switching between processes

Description

The summary-panel (top-right, which includes the commandName, commandLine and parent/child process id's) will occasionally not render when selecting a new process, or after re-selecting a process which had been previously selected and for which the panel previously rendered.

Steps to Reproduce

  1. In NR1, locate a host, and load the Top nerdlet. Select a process other than the one currently selected at load, re-select the original process. The summary panel does not render.

  2. In NR1, locate a host, and load the Top nerdlet. Select a process other than the one currently selected at load, then select another. After several selections, the summary panel no longer renders. Note, navigating using the child/parent link yields the same result.

Expected Behaviour

The summary-panel should load consistently, for every process

Your Environment

  • Versions 0.1.5, 0.1.6
  • Browsers:
    Chrome Version 77.0.3865.120 (Official Build) (64-bit) (Mac)
    Firefox 69.0.3 (64-bit) (Mac)
@throck throck added the bug Something isn't working label Oct 23, 2019
@tangollama
Copy link
Contributor

@throck I can confirm that I was able to reproduce. I'll look into addressing this in the weeks ahead. Thanks for reporting it.

@tangollama tangollama self-assigned this Oct 29, 2019
@danielgolden danielgolden mentioned this issue Jan 29, 2020
Closed
@tangollama tangollama assigned jbeveland27 and unassigned tangollama Feb 7, 2020
@jbeveland27 jbeveland27 linked a pull request Feb 19, 2020 that will close this issue
fix: summary panel nrql query issues (Fixes #10) #20
Merged
Open Source and Developer Advocacy Community Roadmap automation moved this from Committed to Delivered Feb 19, 2020
jbeveland27 added a commit that referenced this issue Feb 19, 2020
@jbeveland27
fix: summary panel nrql query issues (Fixes #10) (#20)
36bb7b9 
* fix: resolves #10 by replacing NrqlQuery with NerdGraphQuery

* fix: add nr1.json to root

* chore: update icon size to address console warning

* fix: use nr1-community timeRangeToNrql and remove custom styling in favor of built-in prop

* chore: just formatting change to try and get GitHub to wake up with the PR commits
devfreddy pushed a commit that referenced this issue Feb 19, 2020
chore(release): 0.4.2 [skip ci]
c77a91a 
## [0.4.2](v0.4.1...v0.4.2) (2020-02-19)

### Bug Fixes

* summary panel nrql query issues (Fixes [#10](#10)) ([#20](#20)) ([36bb7b9](36bb7b9))
@devfreddy
Copy link
Contributor

🎉 This issue has been resolved in version 0.4.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbeveland27 jbeveland27

Labels
bug Something isn't working released
Projects
No open projects
Open Source and Developer Advocacy Co...
  
Delivered
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: summary panel nrql query issues (Fixes #10)
4 participants
@devfreddy @tangollama @throck @jbeveland27