sink: wait for infra-agent to be ready before starting #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes, I noticed that as well, thanks for taking care of it! |
roobre
force-pushed
the
agent-wait
branch
2 times, most recently
from
b1a0636
to
9876189
Compare
| _ = resp.Body.Close() | ||
|
|
||
| if resp.StatusCode != http.StatusOK { | ||
| return fmt.Errorf("%w: %d", errProbeNotOk, resp.StatusCode) |
There was a problem hiding this comment.
perhaps you can get rid of the errProbeNotOk var since is just for loggin
There was a problem hiding this comment.
I planned to do so but I'm not sure if the linter would complain in this case. Since I already had the var created from a previous iteration where this error was somewhere returned) I left it there, but we can remove it if you want!
gsanchezgavier
approved these changes
Jan 28, 2022
fixup! cosmetic refactoring fixup! rename to wrapper.go
Since we are now waiting using the prober, errors POSTing data to the sidecar are actually concerning
Co-authored-by: Guillermo Sanchez Gavier <gsanchez@newrelic.com>
paologallinaharbur
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, after upgrading the
nri-bundleon my local environment, thenrk8s-ksmpod restarted 3 times while waiting for the agent to become ready.nrk8s-kubeletrestarted twice. This simple trick should make a more graceful wait without alerting the user if the agent does not come up immediately.