Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol version #8

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Protocol version #8

merged 2 commits into from
Feb 4, 2019

Conversation

camdencheek
Copy link
Contributor

@camdencheek camdencheek commented Feb 4, 2019 •
edited

Description of the changes

Bump protocol version and add issue templates

PR Review Checklist

Author

  • add a risk label after carefully considering the "blast radius" of your changes
  • describe the intent of your changes in the description. don't just rewrite your code in prose
  • assign at least one reviewer

Reviewer

  • review code for readability
  • verify that high risk behavior changes are well tested
  • check license for any new external dependency
  • ask questions about anything that isn't clear and obvious
  • approve the PR when you consider it's good to merge

@camdencheek camdencheek merged commit a287da7 into master Feb 4, 2019
@camdencheek camdencheek deleted the protocol-version branch February 4, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpheps cpheps cpheps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@camdencheek @cpheps