add username feature

[utsavtulsyan]

No description provided.

[CLAassistant]

All committers have signed the CLA.

[roobre]

Thanks a lot for submitting this! We'll try to provide some feedback as soon as possible :)

[roobre]

Hi there @utsavtulsyan!

So far this is looking nice to me. The only thing I'd miss is covering this use case with an integration test, to ensure we won't break this by accident in future updates.

We have an skeleton for running integration tests using docker in the integration folder, and a fairly simple test suite written in go in the same folder. Please try to take a look and tell us if you'd feel confortably by adding a case for username+password authentication there, in a similar fashion that the one we have for TLS.

If you find it too convoluted just tell us and we'll try to prioritize adding this on our side :)

BR,
Roberto

[utsavtulsyan]

Hi @roobre,
I have added the integration test as suggested, please have a look.
Regards,
Utsav

[roobre]

Thanks a lot @utsavtulsyan!
I've pinged the team for revew, we'll try to leave some feedback as soon as possible! Overall, however, PR is looking good to me so I wouldn't expect for this to take too long or require many changes.

[carlossscastro]

This all looks good @utsavtulsyan
Thanks for the PR.
We'll release it shortly

👍