Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): Add incident title template support #2662

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

baNROne
Copy link
Collaborator

@baNROne baNROne commented May 17, 2024

Description

https://new-relic.atlassian.net/browse/NR-74510
Note, this PR depends on unmerged changes in newrelic-go-client

Please do not merge yet

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

  • Must be on relevant FF
  • Must use this branch of newrelic-client-go
  • Incorporate incident_title_template into any newrelic_nrql_alert_condition
  • Plan and apply

@baNROne baNROne requested a review from akane0915 May 17, 2024 21:16
Copy link
Collaborator

@akane0915 akane0915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and manual testing checks out. Can you please update the documentation here to include the new field? https://github.com/newrelic/terraform-provider-newrelic/blob/main/website/docs/r/nrql_alert_condition.html.markdown#L17

@baNROne baNROne requested a review from akane0915 May 20, 2024 20:50
akane0915
akane0915 previously approved these changes May 20, 2024
Copy link
Collaborator

@akane0915 akane0915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants