feat(alerts): Add title template support #1141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akane0915
suggested changes
May 15, 2024
pkg/alerts/nrql_conditions.go
Outdated
| @@ -273,6 +275,7 @@ type NrqlConditionUpdateBase struct { | |||
| ViolationTimeLimitSeconds int `json:"violationTimeLimitSeconds,omitempty"` | |||
| Expiration *AlertsNrqlConditionExpiration `json:"expiration,omitempty"` | |||
| Signal *AlertsNrqlConditionUpdateSignal `json:"signal"` | |||
| IncidentTitleTemplate *string `json:"incidentTitleTemplate,omitempty"` | |||
There was a problem hiding this comment.
@baNROne I think we'll want to leave off omitempty for NrqlConditionUpdateBase. The reason is because we want a user to be able to remove an incident title template on an existing condition that already has the field configured. This presentation (slides 20-25 particularly) does a great job at explaining the reasoning. https://docs.google.com/presentation/d/1VEYfI7acg8LH_uGHjj5Su4RoF1lQRPVyfxK59xUMxV8/edit?usp=sharing
There was a problem hiding this comment.
Makes sense. Thanks @akane0915. I've updated it.
8 tasks
akane0915
approved these changes
May 20, 2024
fix: Remove omitempty refactor(alerts): Change field name
baNROne
changed the title
baNROne
force-pushed
the
add-incident-title-template-support
branch
from
817de1a
to
03c6197
Compare
akane0915
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://new-relic.atlassian.net/browse/NR-74508
Adds support for
titleTemplateCleaned up some formatting while I was in there
See this PR for related changes in the Terraform provider: feat(alerts): Add incident title template support terraform-provider-newrelic#2662
Please do not merge yet