New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Setting to skip confirmation of marking feeds read #1215
Add Setting to skip confirmation of marking feeds read #1215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good!
We're using two CI providers, and one of them apparently refused to build the code because you just registered with GitHub :) I asked the support what's up with that. I may have to delay merging this because of that — sorry.
Also, out of curiosity: did you find this repo and issue through Hacktoberfest? I'm trying it for the first time this year, and would like to know if it indeed helps attract more contributors. |
yeah, it showed up in the search of Hacktoberfest labelled issues. I guess by adding Hacktoberfest label with the issue would be sufficient for other contributors to look into it. |
I'll make the required changes later today |
@Minoru plz review the PR for requested changes |
@Minoru if the changes looks good , can you please label the PR as "hacktoberfest-accepted" so that it counts toward hactoberfest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks (and works) great! Please fix the little formatting issue spotted by CI, and I'll finally merge this!
I expect this PR will get merged in the next couple days anyway, so I'll save myself the trouble of keeping another label around. ;) |
done formatting |
Excellent! Thank you for the work, @tarishij17! If you enjoyed working on Newsboat, perhaps you'd take a look at other issues? I labelled a few that might be a good start for someone new to the project, but feel free to take any you like — as far as I understand, it doesn't matter for Hacktoberfest what issues you're working on, or if there is an issue at all. (Travis jobs already finished, but the results never made it to GitHub. That happens. I'm merging this anyway.) |
Thanks @Minoru .It was nice working with you! |
No description provided.