Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Setting to skip confirmation of marking feeds read #1215

Merged
merged 5 commits into from Oct 6, 2020

Conversation

tarishij17
Copy link
Contributor

No description provided.

@tarishij17 tarishij17 changed the title Issue #1214 :Add Setting to skip confirmation of marking feeds read #1214 :Add Setting to skip confirmation of marking feeds read Oct 4, 2020
@tarishij17 tarishij17 changed the title #1214 :Add Setting to skip confirmation of marking feeds read Add Setting to skip confirmation of marking feeds read Oct 4, 2020
Copy link
Member

@Minoru Minoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good!

We're using two CI providers, and one of them apparently refused to build the code because you just registered with GitHub :) I asked the support what's up with that. I may have to delay merging this because of that — sorry.

doc/configcommands.dsv Outdated Show resolved Hide resolved
src/feedlistformaction.cpp Outdated Show resolved Hide resolved
@Minoru
Copy link
Member

Minoru commented Oct 4, 2020

Also, out of curiosity: did you find this repo and issue through Hacktoberfest? I'm trying it for the first time this year, and would like to know if it indeed helps attract more contributors.

@tarishij17
Copy link
Contributor Author

Also, out of curiosity: did you find this repo and issue through Hacktoberfest? I'm trying it for the first time this year, and would like to know if it indeed helps attract more contributors.

yeah, it showed up in the search of Hacktoberfest labelled issues. I guess by adding Hacktoberfest label with the issue would be sufficient for other contributors to look into it.

@tarishij17
Copy link
Contributor Author

I'll make the required changes later today

@tarishij17 tarishij17 requested a review from Minoru October 5, 2020 14:34
@tarishij17
Copy link
Contributor Author

@Minoru plz review the PR for requested changes

@coveralls
Copy link

coveralls commented Oct 5, 2020

Coverage Status

Coverage increased (+0.005%) to 57.175% when pulling d645525 on tarishij17:setting-to-skip-confirmation into 31fb2c9 on newsboat:master.

@tarishij17
Copy link
Contributor Author

@Minoru if the changes looks good , can you please label the PR as "hacktoberfest-accepted" so that it counts toward hactoberfest.

Copy link
Member

@Minoru Minoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks (and works) great! Please fix the little formatting issue spotted by CI, and I'll finally merge this!

src/feedlistformaction.cpp Show resolved Hide resolved
@Minoru
Copy link
Member

Minoru commented Oct 6, 2020

@Minoru if the changes looks good , can you please label the PR as "hacktoberfest-accepted" so that it counts toward hactoberfest.

I expect this PR will get merged in the next couple days anyway, so I'll save myself the trouble of keeping another label around. ;)

@tarishij17
Copy link
Contributor Author

done formatting

@Minoru
Copy link
Member

Minoru commented Oct 6, 2020

Excellent! Thank you for the work, @tarishij17! If you enjoyed working on Newsboat, perhaps you'd take a look at other issues? I labelled a few that might be a good start for someone new to the project, but feel free to take any you like — as far as I understand, it doesn't matter for Hacktoberfest what issues you're working on, or if there is an issue at all.

(Travis jobs already finished, but the results never made it to GitHub. That happens. I'm merging this anyway.)

@Minoru Minoru merged commit 1cac0c7 into newsboat:master Oct 6, 2020
@Minoru Minoru linked an issue Oct 6, 2020 that may be closed by this pull request
@tarishij17 tarishij17 deleted the setting-to-skip-confirmation branch October 7, 2020 04:59
@tarishij17
Copy link
Contributor Author

Thanks @Minoru .It was nice working with you!

@Minoru Minoru added this to the 2.22 milestone Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add setting to skip confirmation when marking all feeds read
3 participants