Remove duplicate whiespace from item titles when displaying in list/head #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's definitely a reason to do it at a lower level: filters. If filters see multiple spaces where views only show one, the filters might not work and it'll be very confusing to the user. I think Thanks for taking care of this, by the way. I keep getting distracted lately and haven't even finished the PRs I myself submitted :( |
dennisschagt
force-pushed
the
feature/consolidate-title-whitespace
branch
from
faf9436
to
961642b
Compare
Minoru
approved these changes
Oct 20, 2020
|
Sure, I expect to have time later this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1227.
This only removes duplicate spaces when displaying titles.
It might make sense to remove duplicate whitespaces on a lower level (e.g. in getters like
title()/get_title()or even when retrieving titles inCache) but I'm not sure it is a good idea.