Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile CXX FFI with C++14 #2694

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

dennisschagt
Copy link
Member

I just noticed that the CXX documentation was updated to recommend .std() over using .flag("-std=..."):
dtolnay/cxx@699a12a

@dennisschagt dennisschagt requested a review from Minoru March 6, 2024 18:47
@coveralls
Copy link

coveralls commented Mar 6, 2024

Coverage Status

coverage: 59.893%. remained the same
when pulling cb4946f on dennisschagt:compile-ffi-with-c++14
into bf5743c on newsboat:master.

@@ -1,6 +1,6 @@
fn add_cxxbridge(module: &str) {
cxx_build::bridge(format!("src/{module}.rs"))
.flag("-std=c++11")
.std("c++14")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely forgot that we specify the version here! Please add cross-comments here and in Makefile so we don't forget the next time we bump the flag.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, done

@dennisschagt dennisschagt merged commit 8784c2e into newsboat:master Mar 9, 2024
38 of 39 checks passed
@dennisschagt dennisschagt deleted the compile-ffi-with-c++14 branch March 9, 2024 11:40
@Minoru Minoru added this to the 2.35 milestone Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants