Support running all docker images locally #2698
Conversation
The usermod/groupmod commands, called from entrypoint.sh, cause an ownership change on all files under /home/builder. This includes the files mapped into /home/builder/src by the docker mount option. Moving the mount location outside of home to avoid this potentially destructive operation having an effect on files outside of docker.
| @@ -9,7 +9,7 @@ | |||
| # docker build \ | |||
| # --tag=newsboat-code-formatting-tools \ | |||
| # --file=docker/code-formatting-tools.dockerfile \ | |||
| # docker | |||
| # . | |||
There was a problem hiding this comment.
Why is this needed? It doesn't look like Dockerfiles use anything outside the docker directory.
There was a problem hiding this comment.
This is not strictly necessary, however, I prefer to keep these consistent between all of our docker files.
In the buildtools docker files, I've used a COPY command to pull in the new entrypoint.sh so there it is was necessary to update the path (cirrus seems to always specify the root directory of the git checkout, without option to override it so I did have to include the docker/ part in the COPY command)
| # --mount type=bind,source=$(pwd),target=/home/builder/src \ | ||
| # --user $(id -u):$(id -g) \ | ||
| # --mount type=bind,source=$(pwd),target=/src \ | ||
| # --user root |
There was a problem hiding this comment.
Why do we have to specify the user here?
There was a problem hiding this comment.
The approach taken in this PR requires the entrypoint script to update the user/group id of the builder user.
We need to be root to do that.
However, in the end, we want to run the build commands as the builder user.
The main issue is that cirrus does not expose a way to specify a user, so it will use the user as specified by the last USER statement in the docker file.
Cirrus also does not run the command specified by ENTRYPOINT.
That makes it necessary to specify the builder user at the end of the docker file.
However, locally, we do want to run the entrypoint script as root to fixup the user/group id in the container to match the user/group id of the host user.
That is why the --user root option is necessary at runtime.
There was a problem hiding this comment.
Anyway, this solution feels far too convoluted, so I plan to try a different approach
(specifying the uid/gid at buildtime. If it works I will create a PR in a bit)
|
Closing this in favor of #2729 |
Resolves #2474
Changes based on a stackoverflow post.