This repository has been archived by the owner on Sep 3, 2019. It is now read-only.
AENV-526 - As an author I want to see and write editorial comments #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| comment.isEdited = false; | ||
| }).error(function () { | ||
| deferred.reject(); | ||
| }); |
There was a problem hiding this comment.
success and error handlers have been deprecated in Angular 1.4, I suggest gradually moving towards the normal then() method of the promises.
|
Didn't manage to review everything, just dropped a few quick ideas... |
|
Thanks for your feedback! |
added more tests and some fixes fixed 'then' response for requests jshint fixes validation fix added extra tests
takeit
changed the title
| }; | ||
|
|
||
| /** | ||
| * Retrieves a list of all slideshows assigned to a specific article. |
There was a problem hiding this comment.
should be Retrieves a list of all editorial comments
|
👍 |
takeit
added a commit
that referenced
this pull request
Aug 18, 2015
AENV-526 - As an author I want to see and write editorial comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO