Skip to content
This repository has been archived by the owner on Sep 3, 2019. It is now read-only.

AENV-526 - As an author I want to see and write editorial comments #27

Merged
merged 5 commits into from
Aug 18, 2015

Conversation

takeit
Copy link
Contributor

@takeit takeit commented Aug 11, 2015

TODO

  • - finish pagination
  • - tests
  • - rebase
  • - replace user image

comment.isEdited = false;
}).error(function () {
deferred.reject();
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

success and error handlers have been deprecated in Angular 1.4, I suggest gradually moving towards the normal then() method of the promises.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks!

@plamut
Copy link
Contributor

plamut commented Aug 13, 2015

Didn't manage to review everything, just dropped a few quick ideas...

@takeit
Copy link
Contributor Author

takeit commented Aug 13, 2015

Thanks for your feedback!

added more tests and some fixes

fixed 'then' response for  requests

jshint fixes

validation fix

added extra tests
@takeit takeit changed the title [WIP] - AENV-526 - As an author I want to see and write editorial comments AENV-526 - As an author I want to see and write editorial comments Aug 14, 2015
};

/**
* Retrieves a list of all slideshows assigned to a specific article.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be Retrieves a list of all editorial comments

@thnkloud9
Copy link
Contributor

👍

takeit added a commit that referenced this pull request Aug 18, 2015
AENV-526 - As an author I want to see and write editorial comments
@takeit takeit merged commit 8c9400d into newscoop:master Aug 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants