Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PPDSC-2625): fail build on cms issues #564

Merged
merged 4 commits into from Jan 19, 2023

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented Jan 13, 2023

PPDSC-2625
What

  1. Background - CMS issues failing silently
  2. What did you do - fail build for CMS connection or content issues
  3. What does the reviewers should expect
  • Build should fail if CMS connection fails or content invalid
  • TS support for page content objects

Spike writeup: https://nidigitalsolutions.jira.com/wiki/spaces/NPP/pages/4264067079/PPDSC-2625+Handle+CMS+connection+and+content+issues

Failure examples:
Screenshot 2023-01-13 at 12 15 58
Screenshot 2023-01-13 at 12 22 35
Screenshot 2023-01-13 at 12 34 03

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf added the draft This is a draft PR and not intended for formal review yet label Jan 13, 2023
@mstuartf mstuartf requested a review from a team as a code owner January 13, 2023 12:44
@pp-serviceaccount
Copy link
Collaborator

@mstuartf mstuartf added ready for review Please assist in getting this reviewed and removed draft This is a draft PR and not intended for formal review yet labels Jan 17, 2023
mutebg
mutebg previously approved these changes Jan 18, 2023
@mstuartf mstuartf merged commit 4a442e5 into main Jan 19, 2023
@mstuartf mstuartf deleted the chore/PPDSC-2625-cms-errors branch January 19, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants