Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2829): add inverse focus outline styles #639

Merged
merged 4 commits into from Feb 21, 2023

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented Feb 14, 2023

PPDSC-2829

What

  1. Background - why this is needed
  • Outlines not meeting colour contrast ratios for inverse styles
  1. What did you do
  • Added inverse focus outline styles
  1. What does the reviewers should expect
  • Focus outlines should be visible for inverse components

Screenshot 2023-02-14 at 16 19 12

Screenshot 2023-02-14 at 16 19 24

Screenshot 2023-02-14 at 16 26 59

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf added the ready for design review Please assist in getting this reviewed label Feb 14, 2023
@mstuartf mstuartf requested a review from a team as a code owner February 14, 2023 16:57
@github-actions github-actions bot added the fix This change fixes a bug label Feb 14, 2023
@mstuartf mstuartf added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Feb 17, 2023
@mstuartf mstuartf merged commit 41331a4 into main Feb 21, 2023
@mstuartf mstuartf deleted the fix/PPDSC-2829-inverse-focus-outline branch February 21, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants