Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PPDSC-2829): add inverse focus outline styles #639

Merged
merged 4 commits into from
Feb 21, 2023
Merged

fix(PPDSC-2829): add inverse focus outline styles #639

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
feb4820
fix(PPDSC-2829): add inverse focus outline styles
mstuartf Feb 14, 2023
c0dd6d4
fix(PPDSC-2829): correct filenames
mstuartf Feb 14, 2023
0282bd3
Merge branch 'main' into fix/PPDSC-2829-inverse-focus-outline
mstuartf Feb 17, 2023
09f18cd
Merge branch 'main' into fix/PPDSC-2829-inverse-focus-outline
mstuartf Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions site/components/feature-card/__tests__/__snapshots__/feature-card.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,7 +1246,7 @@ exports[`FeatureCard Renders horizontal card with clickable button only 1`] = `
}

.emotion-12:focus-visible:not(:disabled) {
outline-color: #3768FB;
outline-color: #FFFFFF;
outline-style: solid;
outline-width: 2px;
outline-offset: 2px;
Expand Down Expand Up @@ -1746,7 +1746,7 @@ exports[`FeatureCard Renders horizontal card with clickable button only 1`] = `
}

.emotion-12:focus-visible:not(:disabled) {
outline-color: #3768FB;
outline-color: #FFFFFF;
outline-style: solid;
outline-width: 2px;
outline-offset: 2px;
Expand Down Expand Up @@ -2250,7 +2250,7 @@ exports[`FeatureCard Renders interactive horizontal card with text when no butto
}

.emotion-14:focus-visible:not(:disabled) {
outline-color: #3768FB;
outline-color: #FFFFFF;
outline-style: solid;
outline-width: 2px;
outline-offset: 2px;
Expand Down Expand Up @@ -3421,7 +3421,7 @@ exports[`FeatureCard Renders interactive vertical card with link 1`] = `
}

.emotion-10:focus-visible:not(:disabled) {
outline-color: #3768FB;
outline-color: #FFFFFF;
outline-style: solid;
outline-width: 2px;
outline-offset: 2px;
Expand Down Expand Up @@ -5289,7 +5289,7 @@ exports[`FeatureCard Renders vertical card with clickable button only 1`] = `
}

.emotion-8:focus-visible:not(:disabled) {
outline-color: #3768FB;
outline-color: #FFFFFF;
outline-style: solid;
outline-width: 2px;
outline-offset: 2px;
Expand Down
2 changes: 1 addition & 1 deletion site/components/media-list/__tests__/__snapshots__/media-list.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1318,7 +1318,7 @@ exports[`Media List renders with feature cardscards 1`] = `
}

.emotion-18:focus-visible:not(:disabled) {
outline-color: #3768FB;
outline-color: #FFFFFF;
outline-style: solid;
outline-width: 2px;
outline-offset: 2px;
Expand Down
2 changes: 2 additions & 0 deletions ...s/foundation-page-template/__tests__/__snapshots__/foundation-page-template.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ exports[`Foundation Page Template renders with feature card 1`] = `
--color-interactiveDisabled010: #DEE2E5;
--color-interactiveVisited010: #6454E3;
--color-interactiveFocus010: #3768FB;
--color-interactiveFocus020: #FFFFFF;
--color-inkWhiteSubtle: rgba(255,255,255,0.8);
--color-inkWhiteContrast: #FFFFFF;
--color-inkBrand030: #017582;
Expand Down Expand Up @@ -689,6 +690,7 @@ exports[`Foundation Page Template renders with mandatory props only 1`] = `
--color-interactiveDisabled010: #DEE2E5;
--color-interactiveVisited010: #6454E3;
--color-interactiveFocus010: #3768FB;
--color-interactiveFocus020: #FFFFFF;
--color-inkWhiteSubtle: rgba(255,255,255,0.8);
--color-inkWhiteContrast: #FFFFFF;
--color-inkBrand030: #017582;
Expand Down
2 changes: 2 additions & 0 deletions ...mplates/pattern-page-template/__tests__/__snapshots__/pattern-page-template.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ exports[`Foundation Page Template renders with feature card 1`] = `
--color-interactiveDisabled010: #DEE2E5;
--color-interactiveVisited010: #6454E3;
--color-interactiveFocus010: #3768FB;
--color-interactiveFocus020: #FFFFFF;
--color-inkWhiteSubtle: rgba(255,255,255,0.8);
--color-inkWhiteContrast: #FFFFFF;
--color-inkBrand030: #017582;
Expand Down Expand Up @@ -689,6 +690,7 @@ exports[`Foundation Page Template renders with mandatory props only 1`] = `
--color-interactiveDisabled010: #DEE2E5;
--color-interactiveVisited010: #6454E3;
--color-interactiveFocus010: #3768FB;
--color-interactiveFocus020: #FFFFFF;
--color-inkWhiteSubtle: rgba(255,255,255,0.8);
--color-inkWhiteContrast: #FFFFFF;
--color-inkBrand030: #017582;
Expand Down
16 changes: 16 additions & 0 deletions site/theme/__tests__/__snapshots__/doc-theme.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ Object {
"inkWhiteSubtle": "{{colors.whiteTint080}}",
"interactiveDisabled010": "{{colors.darkBlue080}}",
"interactiveFocus010": "{{colors.focus010}}",
"interactiveFocus020": "{{colors.white}}",
"interactiveInput010": "{{colors.darkBlue090}}",
"interactiveInput020": "{{colors.darkBlue060}}",
"interactiveInput030": "{{colors.blue090}}",
Expand Down Expand Up @@ -589,6 +590,7 @@ Object {
},
"outlines": Object {
"outlineColorDefault": "{{colors.interactiveFocus010}}",
"outlineColorInverse": "{{colors.interactiveFocus020}}",
"outlineOffsetDefault": "{{borders.borderWidth020}}",
"outlineStyleDefault": "solid",
"outlineWidthDefault": "{{borders.borderWidth020}}",
Expand Down Expand Up @@ -2874,6 +2876,7 @@ Object {
"inkWhiteSubtle": "{{colors.whiteTint080}}",
"interactiveDisabled010": "{{colors.darkBlue020}}",
"interactiveFocus010": "{{colors.focus010}}",
"interactiveFocus020": "{{colors.white}}",
"interactiveInput010": "{{colors.darkBlue010}}",
"interactiveInput020": "{{colors.darkBlue050}}",
"interactiveInput030": "{{colors.blue010}}",
Expand Down Expand Up @@ -3330,6 +3333,7 @@ Object {
"name": "docs-accessibility-light",
"outlines": Object {
"outlineColorDefault": "{{colors.interactiveFocus010}}",
"outlineColorInverse": "{{colors.interactiveFocus020}}",
"outlineOffsetDefault": "{{borders.borderWidth020}}",
"outlineStyleDefault": "solid",
"outlineWidthDefault": "{{borders.borderWidth020}}",
Expand Down Expand Up @@ -5615,6 +5619,7 @@ Object {
"inkWhiteSubtle": "{{colors.whiteTint080}}",
"interactiveDisabled010": "{{colors.darkBlue080}}",
"interactiveFocus010": "{{colors.focus010}}",
"interactiveFocus020": "{{colors.white}}",
"interactiveInput010": "{{colors.darkBlue090}}",
"interactiveInput020": "{{colors.darkBlue060}}",
"interactiveInput030": "{{colors.blue090}}",
Expand Down Expand Up @@ -6074,6 +6079,7 @@ Object {
},
"outlines": Object {
"outlineColorDefault": "{{colors.interactiveFocus010}}",
"outlineColorInverse": "{{colors.interactiveFocus020}}",
"outlineOffsetDefault": "{{borders.borderWidth020}}",
"outlineStyleDefault": "solid",
"outlineWidthDefault": "{{borders.borderWidth020}}",
Expand Down Expand Up @@ -8359,6 +8365,7 @@ Object {
"inkWhiteSubtle": "{{colors.whiteTint080}}",
"interactiveDisabled010": "{{colors.darkBlue020}}",
"interactiveFocus010": "{{colors.focus010}}",
"interactiveFocus020": "{{colors.white}}",
"interactiveInput010": "{{colors.darkBlue010}}",
"interactiveInput020": "{{colors.darkBlue050}}",
"interactiveInput030": "{{colors.blue010}}",
Expand Down Expand Up @@ -8815,6 +8822,7 @@ Object {
"name": "docs-theme-light",
"outlines": Object {
"outlineColorDefault": "{{colors.interactiveFocus010}}",
"outlineColorInverse": "{{colors.interactiveFocus020}}",
"outlineOffsetDefault": "{{borders.borderWidth020}}",
"outlineStyleDefault": "solid",
"outlineWidthDefault": "{{borders.borderWidth020}}",
Expand Down Expand Up @@ -11100,6 +11108,7 @@ Object {
"inkWhiteSubtle": "{{colors.whiteTint080}}",
"interactiveDisabled010": "{{colors.darkBlue080}}",
"interactiveFocus010": "{{colors.focus010}}",
"interactiveFocus020": "{{colors.white}}",
"interactiveInput010": "{{colors.darkBlue090}}",
"interactiveInput020": "{{colors.darkBlue060}}",
"interactiveInput030": "{{colors.blue090}}",
Expand Down Expand Up @@ -11559,6 +11568,7 @@ Object {
},
"outlines": Object {
"outlineColorDefault": "{{colors.interactiveFocus010}}",
"outlineColorInverse": "{{colors.interactiveFocus020}}",
"outlineOffsetDefault": "{{borders.borderWidth020}}",
"outlineStyleDefault": "solid",
"outlineWidthDefault": "{{borders.borderWidth020}}",
Expand Down Expand Up @@ -13844,6 +13854,7 @@ Object {
"inkWhiteSubtle": "{{colors.whiteTint080}}",
"interactiveDisabled010": "{{colors.darkBlue020}}",
"interactiveFocus010": "{{colors.focus010}}",
"interactiveFocus020": "{{colors.white}}",
"interactiveInput010": "{{colors.darkBlue010}}",
"interactiveInput020": "{{colors.darkBlue050}}",
"interactiveInput030": "{{colors.blue010}}",
Expand Down Expand Up @@ -14300,6 +14311,7 @@ Object {
"name": "docs-foundations-light",
"outlines": Object {
"outlineColorDefault": "{{colors.interactiveFocus010}}",
"outlineColorInverse": "{{colors.interactiveFocus020}}",
"outlineOffsetDefault": "{{borders.borderWidth020}}",
"outlineStyleDefault": "solid",
"outlineWidthDefault": "{{borders.borderWidth020}}",
Expand Down Expand Up @@ -16585,6 +16597,7 @@ Object {
"inkWhiteSubtle": "{{colors.whiteTint080}}",
"interactiveDisabled010": "{{colors.darkBlue080}}",
"interactiveFocus010": "{{colors.focus010}}",
"interactiveFocus020": "{{colors.white}}",
"interactiveInput010": "{{colors.darkBlue090}}",
"interactiveInput020": "{{colors.darkBlue060}}",
"interactiveInput030": "{{colors.blue090}}",
Expand Down Expand Up @@ -17044,6 +17057,7 @@ Object {
},
"outlines": Object {
"outlineColorDefault": "{{colors.interactiveFocus010}}",
"outlineColorInverse": "{{colors.interactiveFocus020}}",
"outlineOffsetDefault": "{{borders.borderWidth020}}",
"outlineStyleDefault": "solid",
"outlineWidthDefault": "{{borders.borderWidth020}}",
Expand Down Expand Up @@ -19329,6 +19343,7 @@ Object {
"inkWhiteSubtle": "{{colors.whiteTint080}}",
"interactiveDisabled010": "{{colors.darkBlue020}}",
"interactiveFocus010": "{{colors.focus010}}",
"interactiveFocus020": "{{colors.white}}",
"interactiveInput010": "{{colors.darkBlue010}}",
"interactiveInput020": "{{colors.darkBlue050}}",
"interactiveInput030": "{{colors.blue010}}",
Expand Down Expand Up @@ -19785,6 +19800,7 @@ Object {
"name": "docs-patterns-light",
"outlines": Object {
"outlineColorDefault": "{{colors.interactiveFocus010}}",
"outlineColorInverse": "{{colors.interactiveFocus020}}",
"outlineOffsetDefault": "{{borders.borderWidth020}}",
"outlineStyleDefault": "solid",
"outlineWidthDefault": "{{borders.borderWidth020}}",
Expand Down
8 changes: 4 additions & 4 deletions src/banner/__tests__/__snapshots__/banner.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5109,7 +5109,7 @@ exports[`Banner with action and close buttons renders correctly on horizontal la
}

.emotion-13:focus-visible:not(:disabled) {
outline-color: #3768FB;
outline-color: #FFFFFF;
outline-style: solid;
outline-width: 2px;
outline-offset: 2px;
Expand Down Expand Up @@ -5547,7 +5547,7 @@ exports[`Banner with action and close buttons renders correctly on vertical layo
}

.emotion-10:focus-visible:not(:disabled) {
outline-color: #3768FB;
outline-color: #FFFFFF;
outline-style: solid;
outline-width: 2px;
outline-offset: 2px;
Expand Down Expand Up @@ -6058,7 +6058,7 @@ exports[`Banner with close button renders correctly on horizontal layout 1`] = `
}

.emotion-10:focus-visible:not(:disabled) {
outline-color: #3768FB;
outline-color: #FFFFFF;
outline-style: solid;
outline-width: 2px;
outline-offset: 2px;
Expand Down Expand Up @@ -6481,7 +6481,7 @@ exports[`Banner with close button renders correctly on vertical layout 1`] = `
}

.emotion-10:focus-visible:not(:disabled) {
outline-color: #3768FB;
outline-color: #FFFFFF;
outline-style: solid;
outline-width: 2px;
outline-offset: 2px;
Expand Down
7 changes: 4 additions & 3 deletions src/button/style-presets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {StylePreset} from '../theme/types';
import {defaultFocusVisible} from '../utils/default-focus-visible';
import {inverseFocusVisible} from '../utils/inverse-focus-visible';

export default {
buttonSolidPrimary: {
Expand Down Expand Up @@ -125,7 +126,7 @@ export default {
color: '{{colors.inkInverse}}',
iconColor: '{{colors.inkInverse}}',
},
'focus-visible': defaultFocusVisible,
'focus-visible': inverseFocusVisible,
},

buttonOutlinedPrimary: {
Expand Down Expand Up @@ -271,7 +272,7 @@ export default {
backgroundColor: '{{colors.interactiveInverse020}}',
borderStyle: 'none',
},
'focus-visible': defaultFocusVisible,
'focus-visible': inverseFocusVisible,
},

buttonMinimalPrimary: {
Expand Down Expand Up @@ -382,6 +383,6 @@ export default {
loading: {
backgroundColor: '{{colors.interactiveInverse020}}',
},
'focus-visible': defaultFocusVisible,
'focus-visible': inverseFocusVisible,
},
} as Record<string, StylePreset>;
7 changes: 4 additions & 3 deletions src/icon-button/style-presets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {StylePreset} from '../theme/types';
import {defaultFocusVisible} from '../utils/default-focus-visible';
import {inverseFocusVisible} from '../utils/inverse-focus-visible';

export default {
iconButtonSolidPrimary: {
Expand Down Expand Up @@ -125,7 +126,7 @@ export default {
color: '{{colors.inkInverse}}',
iconColor: '{{colors.inkInverse}}',
},
'focus-visible': defaultFocusVisible,
'focus-visible': inverseFocusVisible,
},

iconButtonOutlinedPrimary: {
Expand Down Expand Up @@ -271,7 +272,7 @@ export default {
backgroundColor: '{{colors.interactiveInverse020}}',
borderStyle: 'none',
},
'focus-visible': defaultFocusVisible,
'focus-visible': inverseFocusVisible,
},

iconButtonMinimalPrimary: {
Expand Down Expand Up @@ -386,6 +387,6 @@ export default {
loading: {
backgroundColor: '{{colors.interactiveInverse020}}',
},
'focus-visible': defaultFocusVisible,
'focus-visible': inverseFocusVisible,
},
} as Record<string, StylePreset>;
5 changes: 3 additions & 2 deletions src/link/style-presets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {StylePreset} from '../theme/types';
import {defaultFocusVisible} from '../utils/default-focus-visible';
import {inverseFocusVisible} from '../utils/inverse-focus-visible';

export default {
linkStandalone: {
Expand Down Expand Up @@ -36,7 +37,7 @@ export default {
iconColor: '{{colors.interactiveInverse030}}',
textDecoration: 'underline',
},
'focus-visible': defaultFocusVisible,
'focus-visible': inverseFocusVisible,
},

linkInline: {
Expand Down Expand Up @@ -92,6 +93,6 @@ export default {
color: '{{colors.interactiveInverse040}}',
iconColor: '{{colors.interactiveInverse040}}',
},
'focus-visible': defaultFocusVisible,
'focus-visible': inverseFocusVisible,
},
} as Record<string, StylePreset>;
3 changes: 2 additions & 1 deletion src/menu/style-presets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {StylePreset} from '../theme/types';
import {defaultFocusVisible} from '../utils/default-focus-visible';
import {inverseFocusVisible} from '../utils/inverse-focus-visible';

export default {
menuItemVertical: {
Expand Down Expand Up @@ -109,7 +110,7 @@ export default {
color: '{{colors.interactiveInverse020}}',
iconColor: '{{colors.interactiveInverse020}}',
},
'focus-visible': defaultFocusVisible,
'focus-visible': inverseFocusVisible,
},
menuSubItemVertical: {
base: {
Expand Down
3 changes: 2 additions & 1 deletion src/tag/style-presets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {StylePreset} from '../theme/types';
import {defaultFocusVisible} from '../utils/default-focus-visible';
import {inverseFocusVisible} from '../utils/inverse-focus-visible';

export default {
tagPrimary: {
Expand Down Expand Up @@ -36,6 +37,6 @@ export default {
active: {
backgroundColor: '{{colors.interactiveInverse020}}',
},
'focus-visible': defaultFocusVisible,
'focus-visible': inverseFocusVisible,
},
} as Record<string, StylePreset>;
2 changes: 2 additions & 0 deletions src/theme/__tests__/__snapshots__/creator.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ Object {
"inkSubtle": "{{colors.neutral060}}",
"interactiveDisabled010": "{{colors.neutral020}}",
"interactiveFocus010": "{{colors.focus010}}",
"interactiveFocus020": "{{colors.white}}",
"interactiveInput010": "{{colors.neutral010}}",
"interactiveInput020": "{{colors.neutral050}}",
"interactiveInput030": "{{colors.blue010}}",
Expand Down Expand Up @@ -301,6 +302,7 @@ Object {
"name": "default-theme",
"outlines": Object {
"outlineColorDefault": "{{colors.interactiveFocus010}}",
"outlineColorInverse": "{{colors.interactiveFocus020}}",
"outlineOffsetDefault": "{{borders.borderWidth020}}",
"outlineStyleDefault": "solid",
"outlineWidthDefault": "{{borders.borderWidth020}}",
Expand Down