Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2805): update Ordered list component storybook scenarios #654

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2805

What

  1. Background - updating Storybook scenarios
  2. What did you do - updated Ordered list scenarios
  3. What does the reviewers should expect - new Ordered list scenarios in storybook

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:
image

After:
image

Who should review this PR:

How to test:

@evgenitsn evgenitsn added docs Improvements or additions to documentation ready for design review Please assist in getting this reviewed labels Feb 20, 2023
@evgenitsn evgenitsn requested a review from a team as a code owner February 20, 2023 14:33
@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Feb 21, 2023
Copy link
Collaborator

@JohnTParsons JohnTParsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had replaced "5. echo" with a couple of long sentences to prove that paragraphs were indented correctly but that change seems to have disappeared at some point?!

@evgenitsn In this PR might it might be worth introducing the Storybook changes I made in #612?

@JohnTParsons
Copy link
Collaborator

Ah, my changes are in the v7 branch, not in main, so that explains why not showing on this PR.

@evgenitsn evgenitsn merged commit 9eb45bb into main Feb 22, 2023
@evgenitsn evgenitsn deleted the docs/PPDSC-2805-update-ordered-list-component-storybook-scenarios branch February 22, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants